Building Web APIs Part 3

[@cesarh.delgado4069]

Security with Oauth2 please!!

[@RedScare.]

19:08 Double call of _chinookSupervisor.GetAlbumByIdAsync() does not look right. 21:10 async/await usage overhead

[@TPersistent]

So much boilerplate for such a simple application. I see where it all comes from, but the feeling is that the tooling is all wrong; pounding a square peg into the round hole type of thing. The system should have some reasonable defaults, instead of having to mindlessly redefine every single thing again and again every step of the way.

[@SoyUnEmilio]

The ViewModel sounds like a web application. I would use DTO instead.

[@6freeborn]

DTO = ?

[@SoyUnEmilio]

@@6freebornit stands for data transfer object.

[@reneschindhelm4482]

+1 for the KISS example

[@truman5652]

Superviser it's actually UnitOfWork. I don't see any reason to test CRUD operations in this application. And what about validation and audit of data?

[@BenHayat]

VM or API Model doesn't really apply for Web API. It's standard name is DTO. Why not use DTO. And for the supervisor, it is called "UnitOfWork".

[@heiko3169]

A good guide for starters ..probably.., BUT I strongly criticise the supervisor class! Actually I would call it a bad habbit, because it violates the SOLID principles. You could have gone with provider classes for each of the models. IAlbumProvider that has the methods to retrieve albums, either all or by id or by whatever search parameter.... and so on for all the other viewmodels you have. ..even more advanced you would go for CQRS and you would have QueryHandlers and CommandHandlers (but thats probably out of the scope of this guide which should be a help for starters).

[@nico-toscani]

Supervisor and repositories... I don't think that is necessary. Repos were 'fun' when we had to use the SqlDataReader....

[@heiko3169]

I agree that the supervisor class is in question (actually I would call it a bad habbit, because it violates the SOLID principle). Repositories on the other hand is absolutely fine and recommended to use, even with EF ! Why? Because first of all it provides those data functions you WANT to provide to the domain, and nothing more. The Domain model should NEVER contain query syntax against data entities. That's what repositories provide as function! Second, repositories are better for unit testing: they are mockable, and testable itself.

[@JJZune]

Am I missing something here? This all kind of seems a bit ... clunky. Plus from my understanding the EFCore documentation seems to discourage implementations of the repository pattern (see: docs.microsoft.com/en-us/aspnet/core/data/ef-mvc/advanced?view=aspnetcore-2.0#repository-and-unit-of-work-patterns)

[@gligom]

I think that for this simple project they just write to much code. All over the Internet in all teaching stuf, they say about DRY, KISS amd here i just see alot of same code...

[@alfredcsdinc]

Please Make the Part 1, 2 and 3 Links available

[@ChrisWoodruff]

Part 1 channel9.msdn.com/Shows/Visual-Studio-Toolbox/Building-Web-APIs-Part-1 Part 2 channel9.msdn.com/Shows/Visual-Studio-Toolbox/Building-Web-APIs-Part-2

[@AungBaw]

channel9.msdn.com/Shows/Visual-Studio-Toolbox/Building-Web-APIs-Part-1

[@AungBaw]

channel9.msdn.com/Shows/Visual-Studio-Toolbox/Building-Web-APIs-Part-2

[@EricJavierHernandezSaura]

It is amazing how a project so simple, can be done so wrong !! I had to stop counting how many principles and best practices get violated in this video.

[@ryanconnollyatwork1356]

What are some of the ones that stood out for you?

[@EricJavierHernandezSaura]

@@ryanconnollyatwork1356 That supervisor class is a mess, for example, it breaks the open close principle, the single responsibility principle and make almost impossible to scale that project in the future. Please don't take the criticism the bad way it is what it is

[@ryanconnollyatwork1356]

@@EricJavierHernandezSaura Yeah, I agree with that one for sure. It was a god class that needed to be refactored. He said he didn't like it either, maybe that was a sign.

[@Xenas2127]

@Eric Javier Hernandez Saura I'm quite new to the whole api thing. What would be a better implementation?

[@ryanconnollyatwork1356]

@@Xenas2127 There are a lot of great examples of clean architecture like this one github.com/ardalis/CleanArchitecture

[@MustaphaCM]

first