So after making this video it got me thinking... What are the best qualities in a code reviewer? Let me know in the comments, would be interested to see your thoughts 😊
@CodyEngelCodes3 жыл бұрын
No one gives a damn.
@ChrisAthanas3 жыл бұрын
@@CodyEngelCodes those hacker comments should be deleted
@xanaduzhang1862 жыл бұрын
The best quality of a review - Ask for Better Code, Not Best.
@nromancarcamo11 ай бұрын
Love the tips, I feel 100% relatable due to I have done some of the things you said, but I learn somethings as well, the difference I see is that you have already like a framework in your head, maybe because of your vast experience which is something really good. 👍 You gained a new subscriber.
@dimaorols8143 Жыл бұрын
I'd be straight to be point with things I dislike, and have an open mind. I'd ask questions when I wouldn't understand the intended output for project N, but not to say that I found something wrong with the code. Had a co-worker leaving such remarks: "Don't you think this would've been better?", "Why did you do it this way instead if using our in built code?" That's a bad approach. I rather guide the developer and explain within reason why something might be out of bounds and provide examples.
@sk8sbest3 жыл бұрын
Would love a video on unit tests!
@CodyEngelCodes3 жыл бұрын
I'll add it to the list! ☺️
@robertstitt40043 жыл бұрын
Greetings! I'm also a software engineer here in Chicago! Love you videos!
@CodyEngelCodes3 жыл бұрын
Thanks Robert! Really appreciate the kind feedback ☺️
@gunedaa96217 ай бұрын
This was super helpful as a junior software engineer who hasn't delivered a proper code review before, I especially like that you also take the time to compliment when you see a good piece of code. Do you have any recommendations for code review interviews? I've applied to a job and passed the live coding session and next is to do a code review interview which I haven't done before for any of my previous job applications. Would be super helpful to get your insights :)
@devvilboyy6767672 ай бұрын
Can you give us an example of things you pass or let slide when reviewing and vice versa things that absolutely need to be changed
@月牙天衝-y7u Жыл бұрын
Amazing video. You just gained another subscriber.
@raw_tech_with_tom11 ай бұрын
Going to rewatch this
@saquibsiddique26412 жыл бұрын
Great job 👍 Really helpful 🙂
@CodyEngelCodes2 жыл бұрын
Glad it was helpful!
@shyamagrawal61612 жыл бұрын
Thanks for valuable stuff
@mani65311 ай бұрын
being Senior engineer ,how do we manage our own work along with the PR review , which is quite challenging , which leads to poor code quality.
@ChrisAthanas3 жыл бұрын
Great synopsis
@CodyEngelCodes3 жыл бұрын
Thanks 😊
@naveenkumar-ns9sg2 жыл бұрын
Please do some good video on writing unit test with more details
@CodyEngelCodes2 жыл бұрын
Have you already watched this video? Can you let me know what else you'd like to see covered? kzbin.info/www/bejne/l3rHXoqCj9Opodk
@sashasyrotenko605111 ай бұрын
My TL 35% of comments 65% of changes requested xD
@majorhumbert67611 ай бұрын
This ratio depends on your colleagues and what work you do. I'd say that my ratio is about the same.
@roltthehunter Жыл бұрын
When you say business requirements what do you mean by that? I am curious also great video I am an Android engineer with about 2 years of experience and I have not really had anyone explicitly give me business requirements I feel like maybe I am slipping. Is it something I should be searching out or something that I should just be getting from my manager and lead and stuff?
@CodyEngelCodes Жыл бұрын
Business requirements are just the requirements of the application. If you have an application that loads pictures, loading pictures in a list is a requirement of the business. It's basically just an overloaded term that could be replaced with "how the application functions or behaves".
@Prash52 жыл бұрын
Quality content!
@CodyEngelCodes2 жыл бұрын
Quality comment! Thank you 😎
@azkaarkhatib5 ай бұрын
Successfully accomplished destruction of the like button. 👍💥
@iconelias5082 жыл бұрын
I love reviewing other people's code
@stoicacquiescence2 жыл бұрын
Cody, how do you approach code reviews -for juniors/new grads who’ve just joined and are generally confident but their code has room to improve -for juniors/new grads who’ve just joined who are less confident and their code has room to improve -if you are a senior engineer but new to the code base and/or tech stack and the team expects you to participate heavily
@CodyEngelCodes2 жыл бұрын
Truthfully it's the same for everyone except for folks that are newer to the codebase or programming I expect that I'll need to offer more assistance with resolving my comments. For senior engineers I expect that most comments will either be straight forward to resolve or they'll have a reason to not address the feedback.
@Appiah81802 жыл бұрын
Great video.
@CodyEngelCodes2 жыл бұрын
Glad you enjoyed it!
@anandpatel35807 ай бұрын
Impressive
@laneoscar78472 ай бұрын
thanks from a junior
@steveyoo9342 Жыл бұрын
What do you typically do if there are no unit tests in a pull request?
@CodyEngelCodes Жыл бұрын
Providing it can be unit tested I ask for unit tests to be written and block the PR from merging.
@MoonShadeStuff Жыл бұрын
That’s an easy one. The real question is, what do you do when someone just writes bad tests, e.g. tests that are so small they usually boil down to „the code that I wrote is the code that I wrote“ (code implementation duplication in small unit tests), not as easy of a discussion with some people to block their PR.
@WOUUUTT3 жыл бұрын
are you using Mockito or MockK?
@CodyEngelCodes3 жыл бұрын
MockK all the way.
@phenton912 жыл бұрын
Heh heh... Cody... codes
@CodyEngelCodes2 жыл бұрын
🥳
@valydo39273 жыл бұрын
You can't start with saying you reviewed 1000 PRs as a staff, which is far from impressive, and then immediately make a cringey joke about liking the video. Wait for people to see the actual video, mate. The content is top notch though.
@CodyEngelCodes3 жыл бұрын
Happy to hear you enjoyed the video 😊
@dimaorols8143 Жыл бұрын
Don't talk to developer and put your mind out. Developer might come to you and then you negotiate.
@CallousCoder Жыл бұрын
Naming is utterly useless! A developer that relies on names to understand the code doesn’t crash the code! The fact that us old folks had to track registers and memory addresses should say enough that names are overrated. Especially long ones, ugghh hate those! I’m fine with dealing with p for a person object instance for example. And in maths and physics all formulas also use one or 2 letters and your also not lost.