Full Git Tutorial (Part 6) - Pull Requests & Code Reviews

[@diarmaidmac2149]

Thanks Ben. You are a great teacher and this series is wonderful. Hopefully Googles algorithm sorts itself out as these videos deserve way more views. All newcomers to git should watch them!

[@alexleung842]

you missed the most complex part that requires a tutorial: having a reviewer request changes and the submitter creating a revision

[@BenKadel]

Yeh fair point!! Dang i knew i forgot something!! Cheers for the head up my dude

[@kinnisonPaladin]

I have been looking for a tutorial about that for a while now. So Ben how about an added video to showcase not just the PRs but an actual code review with cinversations going back and forth, rerequesting changes, etc

[@gerac]

Awesome explanation! This video is somehow underated... THANKS BEN!!!

[@agustinflames]

Had to google whether the strawberries are berries or not. Thanks Ben !

[@rafaeljimenezreina1473]

Very illustrative, you had my "Like" before see you burp in a tutorial video. Sorry, but I was watching this a few minutes before lunch time here in Spain.

[@varunaws4432]

Thanks Ben for this Pull request session..thanks once again Your smile is superb 😍

[@abdulmukit4420]

I was watching the video in the office without headphones. Then you started screaming and running. My boss was behind me. Way to get attention... Thanks for the video too...

[@mukundasmedari9880]

You've blasted my eardrums 'Gitttttt'

[@BenKadel]

Giiiiiiiiiittttttttttttt! ;)

[@kayeshparvez]

Nicely explained ! Waiting for the next video in git series

[@kevintanudjaja7597]

sorry noob question, in a big project, who will responsible for reviewing the code? the senior developer? the QC team? or no one review and accept pull directly. also how to test the branch before accepting the PR with just seeing the diff?

[@Hydrophish]

Great video. What happens when the PR is rejected? Do you have to cancel the PR and back out the changes? Or just continue making changes to the current version and update the existing PR?

[@bodilidily]

Fun fact I’ve only ever watched the first 2 minutes of a Ben Kadel video!

[@BenKadel]

Usually the first 2 minutes of a video are used to hook an audience into watching more, i use it as an opportunity to show the audience how handsome, modest and funny I am before that gosh darn blasted terminal hogs all the screen space! ;)

[@andreashuber7653]

Awesome series. Thank so much.

[@liliabekuzinaensosense8987]

You are incredible! Thank you for this course!

[@TR-Ascend]

Can you explain how to use git on the terminal to download and test/review locally a Pull Request? As far as I see this is the way big projects work, thanks!

[@EagerEggplant]

You should never approve without running the code first

[@pabloaf87]

Very informative, thanks!

[@diawanchris]

Hi Ben, this is a nice series. I learn a lot from this series, thanks! I want to ask you a question, is there a way to do a pull requests from CLI?

[@BenKadel]

Hey Diawan! This is actually a super question, so PRs are really platform specific, so PRs are slightly different on BitBucket than they are on Github HOWEVER to answer your question (if you are trying to do PRs on Github) then YES you can "do" pull requests in the CLI. Here is a link to some documentation on the awesome Github CLI (gh): cli.github.com/manual/gh_pr_review which enables you to not only submit pull requests to repos, but also add your reviews to PRs from the CLI. Wooo Woo! Hope this helps and answers your questions!

[@diawanchris]

@@BenKadel I see, so different platform has different PR mechanism. I'll be sure to check the Github CLI, thanks Ben! One more question if you don't mind, do you plan to cover how to combine the small commits into one big commits in this series or maybe another video? I think it's called interactive rebase or something like that. Anyway, thanks for the great contents!

[@BenKadel]

Hey Diawan, Sorry only just seen the whole body of this reply! haha! So actually yes I want to cover rebasing as a whole video on its own, explaining the concept and why its useful but also for "squashing" commits, the thing you are on about, its incredibly useful and i would definitly recommend it. just as a hot tip, if you want to squash locally on your branch you can use the interactive rebase command and instead of specifying another branch (which is the normal usage) you can specify simply an old commit in your branch, like this... git rebase -i HEAD~3 The above command would rebase all the commits up to 3 commits ago, aka a squash and turn all the 3 commits into one commit on top of that commit. Very yummy! But yeh to answer your question defo a rebase video coming in this series! great idea!

[@diawanchris]

@@BenKadel Thanks for replying! I'll try out the command, thanks! Can't wait for the video to come out!

[@shaanjohari2316]

You are great teacher

[@BenKadel]

Thank you so so much this means so much! Glad to help! What topics do you think i should cover next in the git series?

[@shaanjohari2316]

@@BenKadel I think making a best ReadMe file for recruiters for your github profile

[@BenKadel]

Ooooooo now thats a nice idea!! TY

[@shahnazmalik6553]

You are Professional. Could you please make videos on Projects in Github? Please

[@BenKadel]

Thanks so much for this lovely comment, could you tell me a little bit more about the kind of videos that you want? Do you mean me working on projects in github or me explaining projects and their layouts etc in github? Thanks

[@shahnazmalik6553]

@@BenKadel I mean how to use projects tool given inside GitHub to manage linked repositories and so on. The way you explain is really professional and of very high quality. I have already recommended my contacts to watch your GitHub series. Thank you so much.

[@ozankurucu6261]

Thank you bro.

[@ViviFFIX]

That opening... Dude... Audio levels... Sort them out!

[@BenKadel]

Im afraid that was by design ;P ;P you loved it really!

[@ViviFFIX]

@@BenKadel Fix your design! No one wants to be wearing headphones and get their earn drums blown out by the word Git XD

[@BenKadel]

But... but... then i wouldnt get to have heart warming conversations like this one.... plus you can totally get new ear drums, but me, i cant just "change my approach" are you mad!

[@ViviFFIX]

@@BenKadel kzbin.info/www/bejne/i3LFXpuMZ9p1oJY

[@kinnisonPaladin]

@@BenKadel I disagree, please change your approach, I had forgotten the volume on high after watching another video that had ridiculously low audio.. then I played your video, I already had it pretty loud, but it was bearable - before I had the chance to lower the volume your sudden scream almost gave me a heart attack 😞

[@elmagnificent8550]

Wasted 2 mins before the guy actually talks about the topic..

[@BenKadel]

There are video chapters (timestamps) that you can see in the description of the video and also display along the bottom of the video frame (in a sort of chopped up bar) so that you can click the "chapter" (topic title) that you are interested in and skip ahead to that content if that helps at all... Most of my videos have a light hearted intro that is usually about 2 minutes, but i always ensure to have video chapters so that i don't waste anyone's time that wants to get to the meat of the video straight away, you just need to use the timestamps provided.