This episode could have been 13m37s in length, surely...!
@LiveOverflow Жыл бұрын
oooof.... missed opportunity
@hyronharrison8127 Жыл бұрын
@@LiveOverfloweeh leet, leat, same thing
@nesieARK Жыл бұрын
It must be an AI. There is no way the Real liveoverflow would have ever let this slip, He cut it, he render it, he watch it He uploads it. Multiple occasions where an Actual human would have seen the magical number but not an AI.. For an AI it's just a number. Therefore Liveroverflow has replaced himself with an AI
@lukasjetu9776 Жыл бұрын
could, but wans't
@GeorgeValkov Жыл бұрын
@@lukasjetu9776 I think Leet + 9 seconds bonus is also cool. Nice video, now I'm hungry for more XSS.
@efrkool Жыл бұрын
Nice video explaining the issue. One thing that I think is good to mention is what is the underlying mistake. This makes it a better resource for devs and also for researchers. In my humble opinion this is due to the fact that the person implementing this tried to it's own filtering instead of using the native available functionality and/or standard package. The red flag beeing the specific list of characters used for filtering
@xorlop Жыл бұрын
PLEASE do more vids like these! I love the way you explained every bit.
@SoreBrain Жыл бұрын
I'm really into all kinds of quirks of js and I can't believe that knowledge finally paid off and I was able to fully follow a liveoverflow video 🎉
@ChillerDragon Жыл бұрын
Yea its one of the more easy to follow videos for web soydevs like us :D
@VxMxPx Жыл бұрын
This is not really JS problems as some people seems to think. Carelessly treating user's input would always lead to big problems. In general when developing FE applications we rarely set any user provided values in any context that could be evaluated like this. Concatenating user's input with code is just bad practice and big no-no. In general, interesting information, but highly theoretical: so many characters are disallowed while double quote still being allowed. I feel IRL, if such case would be allowed, would be either no input cleaning or stricter rules.
@shapelessed Жыл бұрын
Sadly most websites stubbornly develop their own ways of providing rich text display methods instead of using standards, which generally just tends to expose users to exploits... I know that all too well. Been working on the frontend for a while (please kill me)
@aa-fi9ks Жыл бұрын
I have seen a lot of old codebase concatenating user's input with code, it really isn't that bad as long as you know what you are doing. Also in those applications you just can't rewrite the majority of the codebase just to fix a newly discovered XSS. Sorry I lied it was so damn bad that it has become a joke where the filter list just increases day by day. We slapped on a 5000$ IDS and IPS service and everyone pretends like everything is in control but deep inside we all know that the codebase is on fire. I know Robert had told me for a thousand time that concatenating user input with code is bad, but when deadline is chasing off my a** I just can't help but pray and do it anyway, I just want to go home. Sorry Robert, I swear it will be the last time I do it. Amen.
@BrotWurst Жыл бұрын
you are absolutely right. thats also almost always my first thought. but i have to throw that thought away for a moment because it gets more interessting if you think about all the existing websites who still could have flaws like this. and its also interesting just to see again how sh*tty and dirty compilcated and entangled javascript can be as a scripting language :D
@furiat5981 Жыл бұрын
it kind of is. javascript is dogshit and was made to do simple things when it was created but some clowns said "hold my beer" and other clowns took it seriously, then nodejs happened and embedded webshit posing as fully functional desktop applications known as electron came to be and it's at its worse. Thank God I don't ever was forced to dabble in this cesspool profesionally
@fededamian Жыл бұрын
Great video and explanation, professional, and gets to the point. I think one main takeaway one can get, that would especially help guys who may feel overwhelmed by these injections, is that the core problem here to be spotted while you are testing is the lack of the encoding / filtering of the double quotes, which allows you to escape the context of the string where the contents of the parameter is being injected. After that is just a matter of playing around to see what you are allowed to inject and find a way to run code, which is what these injections are all about.
@AntoshaPushkin Жыл бұрын
It's such a weird filtering when you disallow ( ' and ` but allow " < and >
@fourtwizzy Жыл бұрын
I like this as a reoccurring video. It is nice to be able to decipher what someone was referring to. Given everyone has different levels of knowledge, I would give it a 2 thumbs up. Keep ‘em coming!
@staCats Жыл бұрын
Very insight and presented in a way you can understand. I had no idea about XSS or an and now I do.
@lukasjetu9776 Жыл бұрын
same
@_hackwell Жыл бұрын
neat! these tricks go straight into my notes ! Nice video format too. I'd like to watch more of this kind
@xB-yg2iw Жыл бұрын
This format is fun and useful, please do it again!
@WistrelChianti Жыл бұрын
Wow thanks! It's so important for people to have a handle on this sort of thing so we can be aware of what we need to look out for when writing code.
@forestcat512 Жыл бұрын
Cool format, please more of this :)
@HritikV9 ай бұрын
this was an open tab for so long. greatly explained !!
@KyoSawada1 Жыл бұрын
This was super interesting and fun to learn about. Great lesson! Hope to see more of your content, keep up the great work
@gergelykalman9822 Жыл бұрын
Man, I almost never do websec, so this was fascinating. I learned a ton, your content is always top notch! Thanks for this ❤
@karlkastor Жыл бұрын
Great video! Really well explained and easy to understand. Would like more in this series to just explain a short exploit in a way that anyone can understand.
@galopeian Жыл бұрын
Love this explanation. Would use this as a quick explanation for javascript injection methods in general
@markusjohansson4949 Жыл бұрын
would also work in this example
@yuhanaatmaja Жыл бұрын
as always Xcelent Xplanation....
@XPOnion Жыл бұрын
Super interesting video, liked this very much!
@12... Жыл бұрын
you don't need to write , those tags are all optional and are inserted automatically
@exoZelia Жыл бұрын
This is a really cool format. Had this recommended, never seen your channel. Ngl I thought it was gonna be clickbaity and surface level, but this was great! I subbed
@Sp3cia1m4n Жыл бұрын
wow it's an awesome idea, I always took ton of researches to understand.
@antenna8836 Жыл бұрын
The longer I watched this the more upset I became at web development that 1. they're using direct string replace and 2. they didn't properly sanitize the input but then I became legitimately impressed with the use of the javascript uri the hex encoding, and the use of objects
@typeof-undefined-null Жыл бұрын
Super useful and interesting format. Thanks for sharing
@a.k.b.a.l. Жыл бұрын
Not even a minute of reproduction and I can say "I love this series"
@hydejel3647 Жыл бұрын
great video. learned a lot. would love to see more like it 👍
@thetrends5670 Жыл бұрын
This mean TypeScript devs won't find this vuln, as they type the func to accept only N number of args, and TS will throw runtime error if they try to use N+K args, but in build time there code will create this vuln.
@KirkWaiblinger Жыл бұрын
TS will not throw a runtime error if a function is called with extra arguments. At runtime it's just raw JS and anything goes.
@joechristo2 Жыл бұрын
@@KirkWaiblingertypescript is meant to PREVENT runtime errors from even happening
@KirkWaiblinger Жыл бұрын
@@joechristo2 yeah but it can only type check intentionally authored code. TS will be no help at runtime against injected code, since that's all long after the type-checking time
@JohnnyNilsson83 Жыл бұрын
Super interesting. Thanks for the explanation.
@arkadiymel5987 Жыл бұрын
9:00 Concatenation is executed first and the result is a string, which cannot be assigned to. It's essentially equivalent to writing 1 = 2
@LiveOverflow Жыл бұрын
No, because you get a syntax error ;)
@Qbe_Root Жыл бұрын
@@LiveOverflow I guess nothing gets "executed" because of the syntax error, but JavaScript does know in what order to execute this: first the concatenation, then the assignment. It just so happens that the expression makes no sense using that order
@arkadiymel5987 Жыл бұрын
@@LiveOverflow My bad, I meant parsed, not executed. What I was trying to say is that the reason the expression in the video results in a syntax error is that the addition is treated as the left side of the assignment and is not assignable, and that it is similar to the 1 = 2 case in that regard. I looked it up in the ECMAScript documentation to try to be more precise this time and it seems that the reason it results in a syntax error is that the left side of the assignment is not a valid LeftHandSideExpression (13.3) or because of the second bullet in (13.15.1). The fun thing is that I actually tested that with " true ? 0 : (1 = 2) " before writing the comment and it did fail with a syntax error instead of executing.
@0xteknogeek Жыл бұрын
super cool bug, and great explanation!
@fmaximus Жыл бұрын
About using the name variable, wouldn't that only work on your window? I can't see how the xss would do something nefarious on a targets browser.
@schwingedeshaehers Жыл бұрын
You link them to your website, that redirects with the name "parameter"?
@brypleb5792 Жыл бұрын
@@schwingedeshaehers thanks i was confused
@sebscripts9 ай бұрын
This video started my web hacking journey, Thank you!
@olaola-yh5ge Жыл бұрын
This is great, Insiteful as always @LiveOverflow, can this type of xss vulnerabilities be found in react applications as well ?
@KimYoungUn69 Жыл бұрын
Yes
@SamuelLing Жыл бұрын
if it runs javascript, it runs
@rumplstiltztinkerstein Жыл бұрын
As a Rust programmer, it blows my mind how messy Javascript has become. When a programming language gets obsessed with "convenience", it becomes impossible to keep track of changes. I think browsers should switch to simply running a WebAssembly runtime directly instead of Javascript.
@joechristo2 Жыл бұрын
people are gonna lose track of the difference between asmjs and wasm, thinking they are the same thing thus doing damage to the web as a whole
@tweeko6903 Жыл бұрын
I would love to see more of this new format.
@FuzzyLitchi Жыл бұрын
very fun format! :) learnt a few tricks
@notyou2235 Жыл бұрын
The coolest part about this video was the intro.
@logicerror Жыл бұрын
yes, this was both fun and useful! thanks liveoverflow
@ahmedMohamed-zu2qp Жыл бұрын
Good usage for the new Twitter logo 👏👏
@ganeshdatha8240 Жыл бұрын
It feels like it's a special case of DOM Clobbering, right? We are overwriting the names/definitions of defined variables/functions with our payloads so that they get executed when the page's code calls the overwritten function without knowing it.
@roymoshe7822 Жыл бұрын
A couple of questions: When does the evaluation of the parameter takes place? Right after the function call and before any part of the function takes place? Are there any possible mitigations for this kind of exploit? I mean if this code runs before anything else I don’t see any possibility of mitigations which is wild, but I might be missing something
@joechristo2 Жыл бұрын
i have no idea what i’m talking about (as in the context of the video cuz i haven’t watched it) but JS might use C calling conventions in some cases i think (?) and with those, usually the parameters are passed to the function BEFORE the function gets “called” (as in the CALL assembly instruction) but it really doesn’t matter what the function “is” because it can be overrided to not even use the parameters in the first place but get called by the same name, which might be a security risk if some people don’t know what they’re doing
@roymoshe7822 Жыл бұрын
@@joechristo2 well in the video it’s shown that parameters are evaluated pre call to the function which causes a security risk at a fundamental level since the parameter inserted may contain js code that will run before the call of the function Maybe having input checks before each function calll can be a solution but still it seems clunky and weird
@xelspeth Жыл бұрын
The assignment is evaluated before the function call. It has to because otherwise you couldn't use the return value of assignments in functions. The mitigation for this is to not have it in the first place e.g. sanitizing the userinput before placing it in the dom
@bioblade87 Жыл бұрын
the hex encoding trick is impressive too.
@supergamerfr Жыл бұрын
Most valuable piece of information I saw today
@Roll4Combat Жыл бұрын
This was utterly amazing
@kalinunesferreira815 Жыл бұрын
I really enjoyed this format
@ya_Ra28 Жыл бұрын
Nice, we want more :) Thanks mate, as always.
@ИльяНовоселов-ь7у Жыл бұрын
Как же круто ты объясняешь. Плохо знаю английский, но при этом всё понял
@catmage Жыл бұрын
That's crazy creative. I'd be interested in learning how this could be mitigated. Better input sanitation?
@the6278 Жыл бұрын
awesome format! i learned so much
@TwoTeaTee Жыл бұрын
One of such video which I followed start to end!
@AssemblyWizard Жыл бұрын
For the first solution, what about using square brackets to define an array instead of an object? For the second solution, I believe the "new class b" part can be deleted if you replace the equals after toString with a colon. Great video!
@KirkWaiblinger Жыл бұрын
Agreed that the toString in object literal should work too.... maybe they're trying to be general as far as including the case that different characters are prohibited (for example the colon). I think your suggestion with the array gives a nice way of solving it if curly braces are prohibited too.
@avlidienbrunn Жыл бұрын
@@KirkWaiblinger this! if colon is available, might as well use the first example. If it isnt, but one of many whitespace/line terminator/multiline comment characters are, we can use the second example. [location=name] is a good point!
@joechristo2 Жыл бұрын
but in lua members of objects are referred to by square brackets as WELL as members of arrays because every variable is an object in lua and every variable is an object in JS
@abhaysingh2334 Жыл бұрын
What will be the use case and what it is use for. Sorry just want to know/learn more, for me it looks useless to set an alert for myself
@jaideepshekhar4621 Жыл бұрын
You can set any javascript instead of alert, so you can do anything at the server.
@abhaysingh2334 Жыл бұрын
@@jaideepshekhar4621 so If someone else accesses the same page he will get the same script which I injected
@space_0027 Жыл бұрын
Love this format!
@anion21 Жыл бұрын
Yes, this video was funny, it was useful, and now I find javascript even much more strange than it already was.
@a.for.arun_ Жыл бұрын
Loved it. Please continue.
@Yadobler Жыл бұрын
7:07 I think rust mitigates this by making sure (1) parameters must be expressions, and (2) assignment MUST be statements (that return nothing). That's why "x++" doesn't work in rust. It is just "x=x+1;" but doesn't return value, so it cannot be hacked into other expressions.
@malbacato91 Жыл бұрын
finding an injection that compiles and executes dynamic rust code but filters characters would be quite impressive tho it's an interesting exercise how much you can do without (. I'm unable to come up with anything exciting
@electra_ Жыл бұрын
i think x++ just isnt a thing in rust but you can do x+=1? and well, putting assignments as expressions can be a very common bug even outside of injection, my friend accidentally put an = instead of an == inside of a conditional the other day. it can be hard to catch.
@electra_ Жыл бұрын
my first idea of what you can do without () is pointer shenanigins in order to buffer overflow and stuff so like, you can do basic logic without calling fns, just like ifs and loops and stuff so you can get a value on the stack, get its pointer, use unsafe to write a certain offset away, and thus replace the return address on the stack with whatever you want (probably the address of some other function you want to call) its a bit janky and im sure there is a better way to do this here's a bit of a proof of concept i made which prints out the stack and replaces the return address. weirdly enough, the print call in the flag fn causes a segmentation fault. watching in a debugger shows that it gets to the function successfully, though. this is super finnicky as changing how things are done will change the offset on the stack, ideally you'd want some sort of way to iterate over the diff parts of the stack and detect what looks like the return address. or even more ideally, perhaps if you could call a single closure/user defined fn you could have the return addr stuff set up in there, since a big issue with this is you can't really set up anything else (you wouldn't control the fn return) and then like kinda get screwed by not being able to return safely after the fn finishes. fn flag() { loop { println!("test"); }; } fn main() { let stackvalue: usize = 0x69; let stackaddr: usize = &stackvalue as *const usize as usize; let fnptr: usize = flag as *const usize as usize; let rowsize = 0x4; print!{" ADDRESS: "}; for col in 0x0..rowsize { print!{"{:016X} ", col*0x8}; } println!{}; for row in 0x0..0x30 { let offset = row * rowsize * 0x8; let addr = { stackaddr + offset }; print!{"{addr:012X}: "}; for col in 0x0..rowsize { let addr = addr + col * 0x8; let ptr = addr as *mut usize; let val = unsafe { *ptr }; if row == 0x2B && col == 0x1 { print!{"*"}; unsafe {*ptr = fnptr}; } let val = unsafe { *ptr }; print!{"{val:016X} "}; } println!{}; } print!{"done"}; let mut x = 3usize; while x < 1 { x += 1; } }
@GlorytoTheMany Жыл бұрын
Now if I make a website, how can I avoid exploits like this?
@Bunchachis Жыл бұрын
Just make sure you're using built-in functions to filter user's input. In case of passing data to JS, it would be even better if you use JSON. For PHP it should look like this: x("a", ); Note the lack of double quotes in the second argument. That's because json_encode() wraps the value of $xss in quotes if it's a string.
@heli_9 Жыл бұрын
Amazing, more of these type of videos!
@LorSupra Жыл бұрын
Did I only understand about 20% of this? Yes. Did I watch it all and want more anyway? Also yes.
@nincsx Жыл бұрын
could you upload a video about how to learn effektively?
@shinkurt Жыл бұрын
If this amuses you, you have a lot to learn! And that's exciting
@sullivan3503 Жыл бұрын
Why would the input end up as ""..."" instead of "\"...\""? Why would the quotes not get automatically escaped by the input form?
@LiveOverflow Жыл бұрын
Why would it get automatically escaped by the input form. Or the correct question would be, why would it not get automatically escapes by PHP? Well. Because PHP doesn’t do that automatically. If you want that you need to program that
@r3d_r078 Жыл бұрын
This will be a great series
@navibongo9354 Жыл бұрын
brilliant breakdown
@_chris_6786 Жыл бұрын
But, is this like, preventable with input validation?
@carefulwithmoney4699 Жыл бұрын
Amazing, thank you for this!
@AlissonNunes Жыл бұрын
Would you be able to create an array, instead of an object?
@jacesec6484 Жыл бұрын
This video should have been "The Secret Step-by-step Guide to hacking: Deep Dive" 😂 Great video tho.
@whiskersblues Жыл бұрын
Why cyber security is hard to learn, when learning web development you ask a question and you get the answer, in cyber security you have no one to ask and you don't get the actually answer..
@adrianoverona Жыл бұрын
Loved this one! Please, keep them coming :)
@shayarand Жыл бұрын
I absolutely love this!!!!!! You literally read my mind but I didnt have the guts to ask.
@whiskersblues Жыл бұрын
What are they really looking for in cyber security role? are the courses that we see online really enough? probably not even close, right?
@berndeckenfels Жыл бұрын
Hm does it make sense to cancel out name on top of each page (or can it CSPed?)
@bennymeister Жыл бұрын
Wouldn't it be a little cleaner to just put the payload in an array like this: x(""+[location=name]) ?
@cyanoure Жыл бұрын
What if they use "htmlspecialchars" php function?
@SteveLEKORodrigue Жыл бұрын
I love these videos. Insightful!
@plippero7870 Жыл бұрын
Does the name trick also work in stored xss when another user doesnt set his window name to the xss-payload?
Жыл бұрын
In the 'name' case, is it really an XSS, when you need to open the window with the page in a special way?
@whiskersblues Жыл бұрын
How can I land on the first cyber security job?
@DaveyPerron Жыл бұрын
You should do this with John Carmack tweets!
@nikensss Жыл бұрын
that was amazing, thanks for the video
@KaiaLoken Жыл бұрын
Thank you
@whiskersblues Жыл бұрын
What is a day life in a cyber security job? can you show a real examples of tasks and jobs?
@DEBO5 Жыл бұрын
I’ve never seen an actual real world example of a successful XSS or SQL injection attack. It’s always a stupid example form that was purposefully set up to be vulnerable to such injection attacks. I wish someone could show this working when someone uses proper input sanitization.
@frenches1995 Жыл бұрын
Hi I'm a noob here. I think this is interesting but I don't see how this can be a vulnerability since it can only trigger on a client that you obviously have already access to...
@Zooiest Жыл бұрын
Aren't there many other ways too? Like... "[location=name]," ".a=location=name," A"?location=name:0,"
@Bunchachis Жыл бұрын
clever approach
@Marty_YouTuber Жыл бұрын
i refuse to create a twitter account, and twitter doesn't allow viewing without a account so. i can't look at the links you posted. at least Tiktok allows you to view stuff without requiring a account. but i hate tiktok
@prodeveloper8329 Жыл бұрын
the question is how you will control the window.open() ? probably it is gonna be hardcoded values. please someone explain, i couldn't understand that!!!
@LiveOverflow Жыл бұрын
You execute this from your own domain. So the victim visits your site and you trigger that
@MrNevado Жыл бұрын
Awesome content. Make more like this, please.
@MrEpphrodont Жыл бұрын
Incredible vidéo, thanks !
@shockwave9875 Жыл бұрын
Whatever technical things he say ( which is almost 95%) I don't understand a thing. Could someone help me to learn which tools, languages, etc to understand whatever he says ( at least like all those technical terms).
@ThaLiquidEdit Жыл бұрын
Nice video series idea
@aaravsinha6610 Жыл бұрын
This was awesome. Lots of love.
@Haapavuo Жыл бұрын
Great video, thanks!!
@yassine-sa Жыл бұрын
Please make more vids like this!
@DirkFedermann Жыл бұрын
I like these videos. It also supports my war against too much (unnecessary) JS on Websites and that user input is always bad 😁
@joechristo2 Жыл бұрын
feedback is technically user input so your comments are always bad
@DirkFedermann Жыл бұрын
@@joechristo2 so is yours 🤔😂
@ra2enjoyer708 Жыл бұрын
Yeah let's just ignore the part where the entire setup hinges on a fact of having a badly written server template language (which is all of them that didn't start off a client-render library) coupled with badly written sanitizer interpolating the values directly into the html (that also means no http caching btw). Also it's a problem specific to backend development which uses a badly written server template language for frontend instead of splitting responsibilities. For some reason the brain of a typical developer in this stack completely turns off and they think interpolating values directly into html is completely okay because it's just a string, bro! Bonus points if it lives alongside the code which loads libs from other languages and follows all rituals of cross-language interop with all the boilerplate.
@periclayton1282 Жыл бұрын
I really liked the video and I hope to see more videos like this, they are very helpful