How to make a pull request on an open source project

  Рет қаралды 71,286

Web Dev Cody

Web Dev Cody

Күн бұрын

Пікірлер: 97
@BenRogersWPG
@BenRogersWPG 2 жыл бұрын
I've been a developer for 15 years. Been on GitHub for 10 years, however I have never done a pull request. I'm doing some Arduino development for a hobby and wanted to contribute to a project I care about. This guide helped me, and gave me all the info I need to confidently contribute to the repo. I am happy to report, I just completed my first pull request because of this video. Thanks so much for the great and helpful video!
@codewithlenny
@codewithlenny Жыл бұрын
Same thing here! I've never created a pr despite being on GitHub for 5+ years. I am currently working on a robot with some colleagues and pull requests have been all the buzz around here. Time to get back to the basics ;)
@JohnnieWalkerGreen
@JohnnieWalkerGreen Жыл бұрын
#METOO I came here because of a "pull request." Wish me luck for not screwing anything.
@Mikesco3
@Mikesco3 Жыл бұрын
Same here
@Mikesco3
@Mikesco3 Жыл бұрын
Just completed my first pull request to a project that helped me a lot... The pull request got confirmed too!!! This video was fantastic in helping do that...
@JohnnieWalkerGreen
@JohnnieWalkerGreen Жыл бұрын
@@Mikesco3 Hear hear...
@Mikesco3
@Mikesco3 Жыл бұрын
Just completed my first pull request to a project that helped me a lot... The pull request got confirmed too!!! This video was fantastic in helping do that...
@Mikesco3
@Mikesco3 Жыл бұрын
Great video... I'm so glad you went into the nuance regarding pull requests, a lot of other videos only say what to do, but fail to provide the logic behind it...
@jantack7186
@jantack7186 2 жыл бұрын
Very helpful. Clearly structured in terms of content. The sound quality is very good and the pronunciation is clear. Especially for non-native speakers like me, this makes it easier to follow.
@GennadyPodrezov
@GennadyPodrezov 2 жыл бұрын
Such a great tutorial dude. Very concise, straight to the point yet easy to understand. Impressive job man. I wish all people who are really good at something had the ability to explain it as effective as you do!
@nitika1111
@nitika1111 3 жыл бұрын
You've made this real simple! Made note of steps and feeling ready for my first open source contribution. Thanks!
@WebDevCody
@WebDevCody 3 жыл бұрын
Happy coding! Glad you feel comfortable with git a bit more!
@msstarcheetah
@msstarcheetah 2 жыл бұрын
I was stuck and this came in clutch to clear up my uncertainties, thanks so much!
@sharabhmishra8754
@sharabhmishra8754 11 ай бұрын
Thank you so much bro. I made my first contribution today because of you. Now just waiting for approval
@WebDevCody
@WebDevCody 11 ай бұрын
Let’s go!
@DSCS_ShilpiPrasad
@DSCS_ShilpiPrasad 2 жыл бұрын
Thanks loads!! U really saved me! I've been trying to create a PR for almost about 2hrs when I finally came across this video.
@kerokeromeow
@kerokeromeow 3 жыл бұрын
Thank you so much for this! It was really easy to follow you and finally made my first PR :)
@vnoommuy
@vnoommuy 3 жыл бұрын
Saved for later. Commenting to help with the youtube algorithm. Thank you for your videos and the work you put into them.
@WebDevCody
@WebDevCody 3 жыл бұрын
Thanks I appreciate that!
@jathebest2835
@jathebest2835 Жыл бұрын
This was very helpful and comprehensive for beginners like me. Your explanation is top-notch and I appreciate your effort to film the video. I'll revisit the video when I need to do a group project.
@Sky-yy
@Sky-yy 3 жыл бұрын
Aye whatta conincidence,I was asked to pull a repo at job,using vs code or gitbash. This what I was looking for but I already watched it somewhere else. But my favorite KZbinr uploaded so gonna be watching again.
@WebDevCody
@WebDevCody 3 жыл бұрын
Hope it helped!
@jonholdsworth7351
@jonholdsworth7351 2 жыл бұрын
Very good. Crystal clear and detailed.
@alpachino468
@alpachino468 Жыл бұрын
I've been using Git for many years but I'm still a bit apprehensive forking an open-source project, adding my changes, and then opening a PR, for fear that the repository owner might be a jerk and make me look foolish. Totally understand my fear is irrational, and it's always good contributing to projects, so I hope my insecurities don't put anyone else off... 😊
@sarveshworld
@sarveshworld 3 жыл бұрын
Finally done my first PR... Thanks
@Sky-yy
@Sky-yy 3 жыл бұрын
Just completed this one, amazing one 👌
@WebDevCody
@WebDevCody 3 жыл бұрын
Good! Thanks for watching!
@jwdmsd
@jwdmsd Жыл бұрын
One additional step (that I think you missed) would be to fetch+merge the latest master from upstream into your branch (testing-demo) right before creating a pull request. This is crucial in case there are other commits made to the upstream master while you're working on your branch.
@WebDevCody
@WebDevCody Жыл бұрын
Git pull does a fetch and then a merge automatically
@christopheramoisan
@christopheramoisan 2 жыл бұрын
Thank you I look forward to my first PR
@prazeet7246
@prazeet7246 11 ай бұрын
Great content, Perfectly explained!
@avinashmurmu9070
@avinashmurmu9070 Жыл бұрын
after 11:10 I couldn't understand, too difficult. I understood the problem but why are we writing those commands and what are the different possibilities. Maybe I need to watch some more videos.
@kevon217
@kevon217 Жыл бұрын
Very helpful walkthrough, thanks!
@oluwaseunajibowo7422
@oluwaseunajibowo7422 2 жыл бұрын
Thank you, this is just too precise 🙌
@lordcoco_
@lordcoco_ Жыл бұрын
super clear and helpful! appreciate the demonstration 🙏🏻
@PravinKumar-mc8tz
@PravinKumar-mc8tz Жыл бұрын
Thanks Brother Your Help was Appreciated
@erpadminpspl7868
@erpadminpspl7868 Жыл бұрын
thanks for this it is very helful because this type of video is very less on youtube.
@walidzao
@walidzao 11 ай бұрын
Thanks for the video, straight to the point and informative !
@KnifeChampion
@KnifeChampion Жыл бұрын
Very informative and concise vid thank you
@yuchen3587
@yuchen3587 Жыл бұрын
Absolutely practical and clear!
@rajkishan3690
@rajkishan3690 Жыл бұрын
Thank you Cody ,it was helpful.
@vihaanthora8089
@vihaanthora8089 3 жыл бұрын
Thanks for the video, it was really helpful :) I had a question for you, after the maintainer merges the pull request into the master branch, should we go ahead and delete the branch from our forked repo?
@WebDevCody
@WebDevCody 3 жыл бұрын
you can if you want to just keep your fork "clean". We usually delete all old branches after they get merged to master / main.
@vihaanthora8089
@vihaanthora8089 3 жыл бұрын
@@WebDevCody Thank you, that helps :D
@CiaraMcMahon-p8f
@CiaraMcMahon-p8f Жыл бұрын
Excellent tutorial, very helpful :)
@sepehrsarjami
@sepehrsarjami Жыл бұрын
Thanks, your video helped me a lot! Very well explained and detailed.👍
@Creativeviiibes
@Creativeviiibes 3 жыл бұрын
You are a life saver for me ,found this best video of yours at the right time 🙂...
@LeCyProductions
@LeCyProductions 2 жыл бұрын
So well explained, thank you so much.
@AndresGutierrez-o7o
@AndresGutierrez-o7o Жыл бұрын
This is gold, thank you
@mustafaaal-sahek8055
@mustafaaal-sahek8055 2 жыл бұрын
thanks man, you made it very simple and easy to follow 🔥
@nested9301
@nested9301 Жыл бұрын
wow this video is so helpful !
@sheldonfourie5959
@sheldonfourie5959 3 жыл бұрын
This is really helpful seriously!
@ogo_zita
@ogo_zita 2 жыл бұрын
You are a life saver.
@MrCryoJack
@MrCryoJack Жыл бұрын
This is good Wanted to know as I am starting to learn git
@mohamedaminesaadani1975
@mohamedaminesaadani1975 2 жыл бұрын
thanks a lot mate! It make it simple for me.
@darshantank554
@darshantank554 2 жыл бұрын
Beneficial video Thanks :)
@hardikchavada8974
@hardikchavada8974 2 жыл бұрын
nicely explained 👍
@CaliburPANDAs
@CaliburPANDAs 2 жыл бұрын
if you do "git push upstream master", are you bypassing the PR and merging directly?
@WebDevCody
@WebDevCody 2 жыл бұрын
I think so yes
@Rs-nh7zx
@Rs-nh7zx 2 жыл бұрын
Loved this!! Just wondering after adding upstream, can we do git pull upstream to get all the changes from the upstream master?
@WebDevCody
@WebDevCody 2 жыл бұрын
I think so. If you’re current on the master branch I think you can do ‘git pull upstream/master’ to grab the latest changes from upstream master and merge them into your branch. Although, I’m not 100% certain
@suyash.01
@suyash.01 3 жыл бұрын
very well explained!!
@monicaluo8983
@monicaluo8983 2 жыл бұрын
Love this video!
@internetandcomputerprobe4426
@internetandcomputerprobe4426 Жыл бұрын
informative brother
@peuchex7318
@peuchex7318 2 жыл бұрын
Amazing tutorial! Got to create my first PR and open source contribution thanks to you! One small question tho, what if a PR "A" hasn't been merged into the upstream repo yet and you continue to work on a another PR "B" but you need the changes from the PR "A" to move on? Thanks in advance!
@WebDevCody
@WebDevCody 2 жыл бұрын
You can merge branch A into your branch B and then you’d just have a single PR with the combined code
@SeibertSwirl
@SeibertSwirl 3 жыл бұрын
Good job babe!!
@rubaadel8576
@rubaadel8576 2 жыл бұрын
Thank you very much
@ThomasOlu
@ThomasOlu Жыл бұрын
Thank You!!
@sashaikevich
@sashaikevich Жыл бұрын
Nice theme. What’s it called?
@ahmedayachi5889
@ahmedayachi5889 11 ай бұрын
hello, why git reset --hard upstream/master not git pull upstream master ?
@hilalsemercioglu8599
@hilalsemercioglu8599 9 ай бұрын
a quick question. I'm contributing an open-source project. But my new pr shows the previous changes even if the owner approved & merged my pr. What should I do for preventing this?
@WebDevCody
@WebDevCody 9 ай бұрын
I'm not sure what you mean by previous changes
@MohddAlii
@MohddAlii Жыл бұрын
Do we have to wear a backpack for making a pr?
@WebDevCody
@WebDevCody Жыл бұрын
Yes highly recommend
@bistabishwo
@bistabishwo Жыл бұрын
Thank you so much, this is really helpful. But when I tried " git push origin local-branch" it says permission denied. Does this has to do with what the permissions specified on original repo?
@WebDevCody
@WebDevCody Жыл бұрын
You can only push to your fork if you’re not a collab on the repo
@bistabishwo
@bistabishwo Жыл бұрын
@@WebDevCody I got it, I forked the repo and cloned it from the original repo instead from my forked repo.
@fancyAlex1993
@fancyAlex1993 11 ай бұрын
Couldn't you do git fetch and git merge / git pull after setting upstream instead of git reset ?
@WebDevCody
@WebDevCody 11 ай бұрын
Yes I think so. I don’t remember what I taught in this video, but you should just be able to do a git pull upstream main to get the latest changes. Rebase also works
@yuchen3587
@yuchen3587 Жыл бұрын
I am a bit confused. When I am developing something on my testing branch and there is an update in the upstream repo, I should pull the update into my master branch. But after the pulling, my testing branch is still not updated. Should I then merge my master branch into my testing branch?
@WebDevCody
@WebDevCody Жыл бұрын
yes, you'll need to merge master into your testing branch. You might be able to do `git pull master` should work I think or `git pull upstream master`
@yuchen3587
@yuchen3587 Жыл бұрын
@@WebDevCody Cool thank you for your quick reply!
@jineshjain4722
@jineshjain4722 Жыл бұрын
Best Video
@nivethanyogarajah1493
@nivethanyogarajah1493 Жыл бұрын
Nice!
@thewayfarerseye
@thewayfarerseye Жыл бұрын
Clarification - you have forked and made your changes to a feature branch locally and then pushed to your remote forked repo. Do you think if this was merged to your master and then a PR is raised to the open source repo, would that be the ideal way to avoid the git reset master branch at later point? Or is it done because you want to wait and see the repo owner to validate and only when it is merged with master, you want to merge the same to your forked repo master branch.!
@nickst2797
@nickst2797 4 ай бұрын
Basic notes: 1. Fork 2. git clone 3. git checkout -b testing-branch 4. git add filename 5. git commit -m "message" 6. git push origin testing-branch 7. Pull Request. base_repo: original_author/project_name base: master
@WebDevCody
@WebDevCody 4 ай бұрын
Thanks for these great notes!
@nickst2797
@nickst2797 4 ай бұрын
@@WebDevCody I am extremely sorry for my ignorance and for assuming things. I edited the comment as well. Thank you for the video.
@haseebsheikh6101
@haseebsheikh6101 2 жыл бұрын
Helpful
@nick-pu4zae
@nick-pu4zae Жыл бұрын
👌
@robx_001
@robx_001 2 жыл бұрын
noice
@drelijahmikail3916
@drelijahmikail3916 25 күн бұрын
why steps? just make a menu instead of typing the same again and again
@DadundddaD
@DadundddaD Жыл бұрын
So much words, so fast speaking, but you could really compress all the info, for people for whom it's the first pull request
@christopheramoisan
@christopheramoisan 2 жыл бұрын
Thank you I look forward to my first PR
@vijay-00700
@vijay-00700 Жыл бұрын
Thank you so much
How to Review a Pull Request Like a Senior Developer
15:20
Matt Stauffer
Рет қаралды 24 М.
GitHub Forks and Pull Requests | Step by Step
12:23
Wes Doyle
Рет қаралды 85 М.
Одну кружечку 😂❤️
00:12
Денис Кукояка
Рет қаралды 2,8 МЛН
How to make Pull Request and Open Source contribution
24:46
Hitesh Choudhary
Рет қаралды 17 М.
Contributing to Open Source for the first time
18:25
Meta Open Source
Рет қаралды 272 М.
Complete Guide to Open Source - How to Contribute
41:53
freeCodeCamp.org
Рет қаралды 655 М.
How To Get Started With Open Source
13:03
Web Dev Simplified
Рет қаралды 95 М.
Git Tutorial For Dummies
19:25
Nick White
Рет қаралды 1,2 МЛН
What is a pull request?
8:13
Codecademy
Рет қаралды 146 М.
Git Pull Requests explained - Computer Stuff They Didn't Teach You #5
21:10
Github Workflow for Issues and Pull Requests
11:58
Deanin
Рет қаралды 6 М.