Highlighting a Student Programming Project (Code Review)

[@t0m0b0nes]

Wow, honestly I am a bit overwhelmed (and a little proud) to be on your channel! Thank you, this is absolutely motivating for me, thank you for this coding review! Even though I haven’t done a lot for this project the last few weeks, I will take it on soon. What I really appreciate, is that this could boost my experience in open source coding. I always wanted to join a project, but never had a commit yet. Now I wake up having some messages with ideas improving the code, thank you! I always wished to join a coding community, now here it is! 🙏 Even though my time for coding is a bit rare these days, I do my best to take this opportunity 👍 See you soon and best wishes for you Jacob! 👋

[@JacobSorber]

Thanks for providing good material. And, I'm glad I could provide some motivation. I look forward to hearing about your first OS commit-whenever it happens.

[@t0m0b0nes]

@@JacobSorber 👍 This is what the child in me actually is dreaming about. Seems I should follow him! 😄

[@nomadic-insomniac]

Not sure if its already done but You should do a video on word/byte aligned memory, struct packing and using the __attribute__ syntax

[@tordjarv3802]

I think that code looks really well written and you and your student should be proud of it. It is certainly better than the code written by most students in the C course I was TA in as PhD student. The only two criticisms, besides the once you made, I have is that: 1) Global mutable states should be avoided at almost any cost, since it can be almost impossible to debug. The two linked lists in the data_center module should at least be marked static so that no one can modify them from the outside. Better yet, reify them in to their own type and pass them in as argument where they are needed, in case multiple instances of the lists might be needed in the future. 2) The interface and implementation should be as separated as possible. For instance the vocab_data_t and voclst_data_t should be opaque pointers so that the only way to interact with their associated data is through the provided global functions. Lastly, I think the idea behind the project is really good, and I might start using it myself.

[@JacobSorber]

Thanks, Tor. Solid suggestions.

[@robertstrickland9722]

Would love to see more of these.

[@JacobSorber]

Thanks. I'll see what I can do.

[@julesmarecaux3605]

Thanks a lot for all your videos. I've learned a lot from you about C and programming in general

[@JacobSorber]

You're welcome.

[@TheScoobysteve]

I just finished a C project. That project is the reason I subbed this channel. You'd be welcome to take a look if you need some more content? I'm sure you'd find a lot to talk about in there, as it turns out I have absolutely no idea how to code in C.

[@aasaialangaram6847]

what do you think about competitive programming?

[@lef1970]

Do you have any intro to git type videos? I’d like to use it but an intro before I dig in would be helpful

[@gamar1226]

can you make a suggestion list on your website on topics like electronics ,programming etc. thank,s

[@neerajkale]

The "super sloppy" thing hit me hard. Super hard. Even after so many years, I don't have that patience to write the code modular enough. Let alone maintaining such a nice ReadMe file for github. 😅

[@JacobSorber]

You're not alone. 🙂

[@sukivirus]

We think we are your students too :)

[@JacobSorber]

Yeah, good point. I do hope you're learning a lot from the channel. KZbin can feel a lot less personal than a classroom, but I do feel like I'm getting to know some of you (those who comment often)-at least a little. Thanks for being here.

[@Awwe12675]

I have question how to GUI works and how to program it ? how to make framework and how to make game engine sorry for my bad English

[@LogicEu]

Great video as always Jacob. What do you think of the approach of having one single header file containing all what's necessary for every .c module?? I've been doing it like this lately and I'd love to hear what you might think of it.

[@JacobSorber]

That's usually what I try to do, though I'm sure there's a case out there where it makes sense to deviate.

[@davidramsay9321]

Please explain the makefile _("this is translated") for me. It is something to do witha gettext lib or something,? Have been coding since c64 days and still do not know a lot.

[@JacobSorber]

Please first check out my videos about make and makefiles (if you haven't already). Then, please do let me know what confusions you have. Might inspire a future video.

[@airbus5717]

damn i like this channel are there other C YT channels?

[@aasaialangaram6847]

Your channel == YT Stack overflow Very informative and well edited videos.

[@woolfwh]

Why you don't do a gui tutorial

[@JacobSorber]

Well, I included one GUI a while back (in my pandemic simulator video). And, it's on the list. I'm sure you'll see GUI stuff pop up here if you watch long enough. 😀

[@ronnysherer]

A little bit naming issue??? Naming is horrible!!! You said that vocab_add id pretty clean. Well we have different standards. He has comments like "create new data". Each commented block should be a separate function. The function could be: create_new_data(); create_new_node(); link_nodes(); short and clear! Underuse of const and no use of it for parameters. For example function open_session(char* user, char* passwd) must never change the user and passwd strings! Why aren't they const? Blocks of calling curl_easy_setopt are very similar and repeat few times. Some parameters are identical in all calls. Why aren't they wrapped in a function? The code review is very minimal. It fits universities, but it is far from being an industry code review.

[@JacobSorber]

I think you misunderstood the point of this video. But, fair points.

[@ronnysherer]

It is absolutely possible @@JacobSorber. BTW, I love most of your vides :)

[@toastyPredicament]

arr har har...

[@aasaialangaram6847]

First comment😍

[@JacobSorber]

🏆

[@aasaialangaram6847]

@@JacobSorber 😅🙌🤜🤛

[@venkateshhariharan4341]

@@aasaialangaram6847 hi bro neenga tamilahh?