Are You Doing THIS Modifier Mistake In Jetpack Compose?

[@moisesvalera3597]

Can we have a video getting deep into SideEffects?, what a nightmare they have been for me

[@Internet_Ghost-GA]

dude how amazing you are in programming . the way you write codes make me feel the programming is very very easy

[@ashaluwalakazeem9063]

I was able to point out the problem before watching your explanation 😂😅. Thanks, Philip 🙏. I have learned many Android cool tips from you 😊.

[@Detonat0r]

I did exactly this mistake yesterday, and I faced the issue you described

[@ruskiikoshka]

Learned this the hard way XD Nice tip.

[@eelbaz1]

Great explanation. So, in this case, we should pass the background color as a parameter as well, in order to make the button reusable

[@aza749]

Could make a button class with a few templates of button that can be reused in different contexts

[@ubersticks]

I know that passing a defaulted Modifier is good practice, but this always seemed to me like a very awkward "backdoor" since it is not clear what the caller is expected to modify. There is no clear expectation as opposed to the other function parameters.

[@OrlanDroyd]

Clean 😎

[@erickmutura8512]

You see that onclick function behind you has been disturbing me for the last 6 hours I didn't know how to implement it since I wanted my cards to be clicked and you have helped me solve it also its midnight so I can sleep easy tonight so thanks and God bless

[@AldrinMayor-ne5cd]

Thanks for this 💯💪

[@mohancena8970]

Thanks philipp ❤

[@pumaelgatosiberian5047]

Do we need wrap onclick in remember? Seems like we create new lambda every recompose

[@september669]

It's needed, but there is a bug in the modifier.clickable due to which remember won't help

[@manojmaheshwari]

Love jetpack compose

[@UsamaThakurr]

Can you please do a free KZbin course on Android Development with Jetpack Compose? I am sick and tired of using React Native I hate it

[@PhilippLackner]

Already have a crash course 🤔

[@UsamaThakurr]

@@PhilippLackner yes I have watched it completely but I still am unclear and can't create simple projects your recent video on Roadmap of Android Development you suggested to create projects but I am really having a hard time since Jetpack Compose is still very new and also do I have to learn XML now that we have Jetpack Compose?

[@vibovitold]

​@@UsamaThakurrin my opinion yes, because xml is still pretty common. And it's not like it's getting deprecated any time soon.

[@nesletchimaew9209]

I always have a size or height and width parameter in my reusables. I also have a class to calculate size using px, dp, sp or a combination of them

[@vibovitold]

converting between pixels and Dp etc. is covered by Kotlin's standard libraries. your class is reinventing the wheel.

[@nesletchimaew9209]

@@vibovitold no it's not lol it is all depending on local density

[@vibovitold]

@@nesletchimaew9209 yes, you obviously have to pass the density to the converter, eg. to the toPx function. that's why it's an extension function of the Density interface. it doesn't change the fact that it's already implemented. all you've got to do is something like with(LocalDensity.current) { someValueInDp.toPx() } and thta's it. if you've rolled out a custom class for such calculations, you're doing it wrong.

[@Marcix456]

Also, shouldn't modifier be passed at the end with .then(modifier) extension? Modifier is order sensitive, and passing a modifier at the beginning can break effects created by further extensions.

[@vibovitold]

Exactly. With the current implementation you can't override the hardcoded background colour, for example. And what's worse, without looking into the actual implementation you will have no idea which attributes can, and which cannot be overridden by a modifier argument. Which makes for poor API.

[@John-qt6qk]

Thanks

[@jpdsah]

I think we can override the size params from callee

[@kskfernando2945]

What is that IDE theme? It's beautiful

[@AmitJayant]

I have asked this several times in his various videos. Didn't get the answer 😢

[@ficc666]

​@@AmitJayantHe uses Xcode dark

[@goodluck3409]

❤

[@ChrisAthanas]

Modifier is supposed to be the first parameter in a composable

[@davidesorcelli6873]

First optional parameter of a composable function

[@ChrisAthanas]

@@davidesorcelli6873 yes Where else where that be used?

[@davidesorcelli6873]

@@ChrisAthanas I mean Modifier, in your composable function signature, should be the first optional parameter. In your first comment you said that should be the first parameter at all.

[@purplehazer417]

'mistake' in your videos in not a suitable word :)

[@PSK005]

✌️✌️

[@BDCCN-NguyenKiemTan]

Modifier hoisting

[@warTag68]

This is not a bug its a design. The first time u will have to reuse this component you will just refactor 😂😂😂😂 Stop making trivial stuff sound very serious. None of us get stuff right the first time.

[@Kanha0321]

What about MaterialTheme.colorScheme.primary

[@BlueWhaleYT]

this one you said is material 3

[@Internet_Ghost-GA]

dude how amazing you are in programming . the way you write codes make me feel the programming is very very easy

[@manshalkhatri9289]

❤