RailsConf 2015 - Implementing a Strong Code-Review Culture

By Derek Prior
Code reviews are not about catching bugs. Modern code reviews are about socialization, learning, and teaching.
How can you get the most out of a peer's code review and how can you review code without being seen as overly critical? Reviewing code and writing easily-reviewed features are skills that will make you a better developer and a better teammate.
You will leave this talk with the tools to implement a successful code-review culture. You'll learn how to get more from the reviews you're already getting and how to have more impact with the reviews you leave.
Help us caption & translate this video!
amara.org/v/G6iP/

[@cutelittleball]

Man, thank you so much for repeating all the questions before answering them.

[@krtecek-who-tries]

It's 2021 and this talk is soo relevant! The speaker's way of explaining his points is tremendous - very simple, clear and easy to perceive. Thank you!

[@fakefarm]

NOTES: - Reasons for code review are not just code: they include knowledge transfer, increased team awareness, finding alternative solutions - As an author, provide sufficient context (2 paragraphs) - As a reviewer, ask don't tell (offer compliments, overcome negativity bias, be positive) Ways to frame questions and soften suggestions; - what do you think about..? - did you consider...? - can you clarify...? Great talk, Derek! Gotta run. I left off at 19:46.

[@lubokanev7436]

Thanks man, I hope finish the notes .. ahh it's been a year

[@florianliebhart4290]

Very very good! I really liked the talk, especially the fact that he focuses on how to keep good inter-human relationships during code review, more than he focuses on technical hints, since this is more important. I especially like the part starting at minute 16:00, where he talks about positive feedback as opposed to "Why didn't you just...". I've seen this happening in companies. So thanks a lot!

[@dreamerchawla]

Great talk on code review. Gives a lot of clarity and direction on how this can be healthily adopted into the team.

[@KeyserTheRedBeard]

spectacular video Confreaks. I crushed that thumbs up on your video. Maintain up the wonderful work.

[@erikecoologic]

Great talk on a topic that's very important but doesn't get much attention.

[@lukaslukac8680]

11:30 about the difference between written and spoken communication. I definitely agree that the same content can come up as impolite, strict in written form and totally fine in spoken form and I think there is one important thing to do before you apply code review culture. I like to build a relation with the colleagues and come to an agreement that whatever comment is added to the code review is just for learning, helping purposes and should be taken in that way. Then you don't need to spend time on "polite things" and focus on your common goal as a team which is to deliver higher quality code and leave the ego aside.