Ok, I'm still traveling but I had already recorded this one a while back and just edited it.
@BurhanAijaz Жыл бұрын
you still uploaded
@yang5843 Жыл бұрын
Thanks Neet, enjoy your vacation
@vixguy Жыл бұрын
Thank you
@dennisgatere7821 Жыл бұрын
A missed opportunity for this question IMO is counting sort, just tried it and it beats 99% when I submitted it but you need shifting for negative values, check it out and hopefully one day you add it to the channel. public int[] sortArray(int[] nums) { if (nums == null || nums.length == 0) return new int[]{}; int shift = Integer.MAX_VALUE; int max = Integer.MIN_VALUE; for (int num : nums) { shift = Math.min(shift, num); max = Math.max(max, num); } max -= shift; int[] counts = new int[max + 1]; for (int num : nums) { counts[num - shift]++; } for (int num = 0, i = 0; num < counts.length; num++) { while (counts[num] > 0) { nums[i++] = num + shift; counts[num]--; } } return nums; }
@DmitriyKl Жыл бұрын
For those struggling to understand this solution, there's actually a slightly more straightforward way that was easier for me to understand. The overall approach is the same, there are 3 distinct steps: 1 - check if base case 2 - sort left and right halves 3 - merge sorted halves the solution becomes: # base case - array already sorted because len is
@tunguyenxuan8296 Жыл бұрын
At 16:00, the code must be arr[i] = left[j]. The solution will actually work if you put it nums[i] = left[j] as you will assign nums to arr, but for the correctness, it must be arr inside merge function
@karanssh Жыл бұрын
great catch. since it's passed by reference it's pass.
@adarshsasidharan254 Жыл бұрын
I also noticed that and got confused, thanks for the comment
@snoopdogg_007 Жыл бұрын
Good catch! I had similar doubt why using nums instead of arr at 16:00
@metarus208 Жыл бұрын
awesome catch!
@aliramazani202410 ай бұрын
Great job. However, the code below is slightly more efficient than your code because it performs all operations on the original list instead of creating new lists 'left' and 'right'. Overall, it was great to learn your approach as well. def mergeSort(arr): if len(arr) > 1: # Finding the mid of the array mid = len(arr)//2 # Dividing the array elements L = arr[:mid] # Into 2 halves R = arr[mid:] # Sorting the first half mergeSort(L) # Sorting the second half mergeSort(R) i = j = k = 0 # Copy data to temp arrays L[] and R[] while i < len(L) and j < len(R): if L[i]
@varshasingh12995 ай бұрын
Yes, this is even better
@HoppyGamer Жыл бұрын
One of the cleanest explainations of Merge Sort on YT
@adrianfrankowski3784 Жыл бұрын
You can precalculate len(left) and len(right) in merge function to make it a little bit faster.
@bombrman199423 күн бұрын
this video would get more than a million videos if it was named properly and included anywhere in description or title the tag "merge" sort, most people explain it so vaguely
@degamer106 Жыл бұрын
I used heapsort. Do you recommend knowing the other algorithms by heart like Mergesort, Quicksort, etc.. for interviews?
@garth2356 Жыл бұрын
I don't know what you mean by "know them by heart" but you should be able to write those algorithms and understand what every statement does so that you can manipulate them according to your need.
@cosepeter2197 Жыл бұрын
Your explanations are a thing of beauty ❤
@rahulsbhatt4 ай бұрын
Thanks, had to revise this after seeing today's daily.
@dheerendrapratapsingh94064 ай бұрын
Best explanation of mergeSort so far
@malakgghАй бұрын
there are no reason to use two pointers L and R. its same if we create a new sub array each time!! like this: l_arr = merge_sort(arr[:m]) r_arr = merge_sort(arr[m:])
@DimaLifeIsGood Жыл бұрын
Nice, explanation of concept, simplicity of code is amazing, thank you for doing it :)
@krateskim4169 Жыл бұрын
Awesome explanation
@TheSiddhaartha7 ай бұрын
The two arrays in *merge* method, still overwrite the *nums* array. In python, array slice copies by reference and not value. So better use .copy after slice eg arr[L:M+1].copy(). Otherwise answers are incorrect on computer. Maybe LeetCode accepted it with some sort of inbuilt conversion but Python interpreter gave incorrect results. So I used .copy() which solved the problem.
@ttrey74317 сағат бұрын
That is only if the items in the original list are non-primitives. For a list with primitives it's a copy by value.
@khyunwoo18 ай бұрын
this question was asked inside the "insertion sort" lesson on neetcode D:
@doc94487 ай бұрын
I noticed that too. I skipped it there, marked the lesson complete and came back to it in the merge sort lesson (it also appeared there in the leetcode section)
@ahmadbasyouni91734 ай бұрын
@@doc9448 i think its there for you to do insertion sort
@rayray663 ай бұрын
this was amazing!
@mahendrakoteri92334 ай бұрын
I did try Quick Sort but still got TLE.. so here I am
@u4rr837 Жыл бұрын
I passed this problem on leetcode using quick sort. just randomly choose pivot and randomly separate elements with same key. It's quite inefficient though.
@ValhaVaiyagam3 ай бұрын
Thank you Boy..
@sarvesh6785 Жыл бұрын
I was waiting for your video. Great explanation as always 🔥🔥
@hasibqureshi6409 Жыл бұрын
it is not that official channel. but videos are same. how .? no copy right issue?
@mufaddaltatiwala2199 Жыл бұрын
You don't need to pass arr as an argument to the merge and mergeSort methods since they are already inside the sortArray, instead you can simply modify the nums array from both these methods and return nums in the end
@pwnweb5734 Жыл бұрын
need an heapsort solution too :/
@DEVANSHGOYAL-i7h Жыл бұрын
Why is i initialized with L and not 0. what is the problem if we initialize i = 0?
@YINXUANYIN Жыл бұрын
Hi, I also have this problem. Have you solved it?
@valorantfever3990 Жыл бұрын
Heap sort is not better than merge/quick overall , but its memory efficient. You should have gone for heap sort bro :(
@mirshodoripov1035 Жыл бұрын
why is not Quicsort working for this problem?
@mirshodoripov1035 Жыл бұрын
class Solution: def sortArray(self, nums: List[int]) -> List[int]: import random if len(nums) < 2: return nums # base case else: random.shuffle(nums) pivot = nums.pop() # recursive case less = [nums[i] for i in range(len(nums)) if nums[i] pivot] return self.sortArray(less) + [pivot] + self.sortArray(greater) return nums
@benpurcell5914 ай бұрын
It's because one of the problems forces it into worst case which becomes n*n which causes tle
@penguinduck59793 ай бұрын
Quicksort's worst case time complexity is n^2 which does not satisfy the nlogn time complexity requirement
@PannyaTrehan5 ай бұрын
d
@BurhanAijaz Жыл бұрын
it was kinda easy problem
@MeanSoybean Жыл бұрын
almost as if array sorting is one of the first things taught in DSA