Get the source code for this video for FREE → the-dotnet-weekly.ck.page/httpclient Want to master Clean Architecture? Go here: bit.ly/3PupkOJ Want to unlock Modular Monoliths? Go here: bit.ly/3SXlzSt
@balakrishnan-gf9rw10 ай бұрын
Hi Milan, I have a correlation Id in my web api. I used typed http client in mvc core 6 application. So in that case how to pass x-correlation Id in all my web API from client. Kindly suggest me..
@davearkley7014 Жыл бұрын
I've been using named clients, but like the idea of strongly typed clients so may try them out. One advantage of being able to apply configuration once is that you can add Polly retry policies and they will be used for all instances of the named/typed client.
@zfold4702 Жыл бұрын
Where is your post?
@metaltyphoon Жыл бұрын
Strongly typed and singletons have problems, so watch out.
@davearkley7014 Жыл бұрын
@@zfold4702 ?
@MilanJovanovicTech Жыл бұрын
Named clients are awesome
@hamitkarahan2973 Жыл бұрын
Last part was very nice Milan. Many thanks. I preferred named clients many times in projects. I didn't prefer typed clients because I was a little afraid to delve into this lifetime issues when my services are singleton. I am just basically calling CreateClient method in my infra layer with a using() block. This approach didn't give me any problem so far in production.
@PippiTheLongSock Жыл бұрын
I think you shouldn't manually dispose the instance. I am pretty sure the framework does that automatically.
@MilanJovanovicTech Жыл бұрын
I agree, if it works don't fix it. Right?
@hamitkarahan2973 Жыл бұрын
@@MilanJovanovicTech Yesss 😁
@michaelchudinovАй бұрын
Well explained and practical oriented step by step tutorial. Thank you!
@MilanJovanovicTechАй бұрын
Glad you enjoyed it!
@mylesdavies9476 Жыл бұрын
Nice, have been working with typed clients for a while and find it to be a good approach. The only thing I do differently is inject configuration into the typed client and assign any required headers with the constructor, keeping the configure services nice and clean.
@MilanJovanovicTech Жыл бұрын
I think it's better to do the common things inside of AddHttpClient
@mylesdavies9476 Жыл бұрын
@@MilanJovanovicTech fair enough, any particular reason?
@JUTO_MTL Жыл бұрын
I do exactly the same because i didnt figure out how to retrieve configuration with Option Pattern. I get null from the IConfiguration inside the HttpClient Configuration method. If someone have any idea
@ArnonDanon Жыл бұрын
Great content as always Milan...thank you🤴🏻
@MilanJovanovicTech Жыл бұрын
You're welcome!
@niezebenmansour3736 Жыл бұрын
Thank you for the effort in this video!
@MilanJovanovicTech Жыл бұрын
You're welcome :)
@Javilingys10 ай бұрын
What about using Transient HttpClient service inside Scoped Services? Its ok?
@MilanJovanovicTech10 ай бұрын
No scoped services were used here
@vibes992000 Жыл бұрын
Must awaited video. Thanks.
@MilanJovanovicTech Жыл бұрын
Hope you enjoyed it!
@csegyud Жыл бұрын
It was a nicely built overview. Thank you!
@MilanJovanovicTech Жыл бұрын
Glad you liked it!
@JamesSecretofski Жыл бұрын
Thanks for the infiniteTimeSpan. Cool tip 👍
@MilanJovanovicTech Жыл бұрын
Don't mention it 😁
@d3vil5oldier Жыл бұрын
That's exactly what i was looking for, thanks Milan. Just one question, where do you think those typed clients belong to - Application layer or whatever?
@jaomartins1994 Жыл бұрын
Infra
@MilanJovanovicTech Жыл бұрын
HttpClient could lead you to place it in Infrastructure You could create an interface in Application, however
@astroGTC Жыл бұрын
Great !! keep the good work !
@MilanJovanovicTech Жыл бұрын
Thanks, will do!
@diogosilva3637 Жыл бұрын
Great explantion! Will you make a tutorial about Refit? Thanks!
@MilanJovanovicTech Жыл бұрын
Perhaps, I like that library. Maybe to compare it with HttpClient
@ershadnozari Жыл бұрын
You can inject a httpclientfactory instead of httpclient in a typed client to get around the singleton issue.
@MilanJovanovicTech Жыл бұрын
What's the point of using a typed client then?
@VascoFernandesBuenoJunior Жыл бұрын
O think you need to make another video explaining how to add retry using Polly. I recomend to use Backoff.DecorrelatedJitterBackoffV2 in this case.
@MilanJovanovicTech Жыл бұрын
Will do, great suggestion
@palpie Жыл бұрын
You should show the strongly typed version using an interface instead.
@MilanJovanovicTech Жыл бұрын
You don't need interfaces for everything 🤷♂️
@kodindoyannick53287 ай бұрын
Very good content! Thanks Milan.
@MilanJovanovicTech7 ай бұрын
You're very welcome!
@ImranAdam-h1p11 ай бұрын
Great Video Milan! Do you have a video showing how you would unit test this pls? (unit test IHttpClientFactory).
@MilanJovanovicTech11 ай бұрын
I don't yet, sadly. But I would take a look at MockHttp: github.com/richardszalay/mockhttp
@wdorsett84 Жыл бұрын
Great video! Thank you! Just to confirm when using named clients, the concern over transient vs singleton lifestyles isn't a concern? It's just with typed clients?
@Sanabalis Жыл бұрын
Correct. Since you use a factory to create the named client inside the method each time you invoke it, the lifetime of the class instance is not a factor at all. This is true only if the named client is created inside the method. However, should you create (and capture) named clients inside the constructors, you will effectively introduce the same issues as when using the typed client. Capture the factory instead.
@MilanJovanovicTech Жыл бұрын
Yes, since with named clients you create an instance and dispose of it. If you capture the client in a field, you have a similar issue
@WDGKuurama Жыл бұрын
What i don't understand i why does it hate to make a new instance of the class injecting the httpclient if we could have a singleton do avoid being garbage collected all the time, is there issues with such techniques?
@MilanJovanovicTech Жыл бұрын
A new instance of which class?
@grm360 Жыл бұрын
Nice content as always! Could you make a video on how to use Swagger documentation with minimal api?
@MilanJovanovicTech Жыл бұрын
What's to be covered there?
@toragodzen Жыл бұрын
Hi, great video! I've just subscribed and I want to ask about the difference between the EShop and Gatherly projects, which one is better to learn from?
@MilanJovanovicTech Жыл бұрын
They're slightly different, cant' say one is better than the other
@ALOKSHARMAMD Жыл бұрын
you said using httpclient in traditional way can exhaust ports in long run, but is this true if we are doing proper dispose by applying using statements?
@MilanJovanovicTech Жыл бұрын
Yes - you'd end up creating too many handler instances. You want it to be long-lived
@coder31237 ай бұрын
If I were to call API2 from my API1 and the API2 accepts the bearer token that API1 call has is there a way to pass that as header using this method?
@MilanJovanovicTech7 ай бұрын
You can either create a request object, and set the header. Or set the DefaultRequestHeaders on the HttpClient
@Lazzerman42 Жыл бұрын
Thanks! Very well explained and clear code examples! I use the RestSharp for know - because it has support for oAuth1(I need it for an old smartHome device). Are there any helpers for oAuth1 and HttpClient?
@MilanJovanovicTech Жыл бұрын
I am not sure, to be completely honest
@DrHeinzDoofenshmirtz11 ай бұрын
Is the last solution for types clients with the lifetime settings a valid and good approach to use? or is it more on the hacky side? I have never stumpled upon it, and I knew almost everything else in the video. Though it was much more well explained than I have read.
What if I just call AddHttpClient() and inject HttpClient into services contstructors? Do they share the same instance or every service gets its own copy?
@TheMichaelos Жыл бұрын
I wanted to ask the same question! @MilanJovanovicTech I would really appreciate if you could elaborate on differences between factory injection and direct client injection 🙏
@MilanJovanovicTech Жыл бұрын
In theory, it shouldn't work - because no HttpClient would be wired up for that service
@VijayKumar-wy9ku Жыл бұрын
If I'm using 10 different named clients, then 10 object of HttpClient is created using IHttpClientFactory. How can we configure a single instance of HttpClient throughout whole application?
@MilanJovanovicTech Жыл бұрын
Well if you want to 10 _DIFFERENT_ named clients, you have no other choice
@pigrebanto7 ай бұрын
ok but what if the token expires and you need to renew it / pass-in it again? to me it seems that with Factory approach you configure it statically at application startup phase.
@MilanJovanovicTech7 ай бұрын
Use a delegating handler
@DavideSansoni2 ай бұрын
Great Video!! Just a curiosity: what VS theme are you using? Looks very clean
@MilanJovanovicTech2 ай бұрын
It's ReSharper
@DavideSansoni2 ай бұрын
@@MilanJovanovicTech thank you 🙏🏻
@AyoJAjayiАй бұрын
Thanks for this lesson
@MilanJovanovicTechАй бұрын
My pleasure!
@johntotetwoo Жыл бұрын
great video but I am wondering how you can configure with token that expires?
@MilanJovanovicTech Жыл бұрын
DelegatingHandler
@Ram92026z Жыл бұрын
Hi @Milan. This was an absolute great video and I am learning a ton from this channel and so, thank you. Hey, how can I use the above method (the 3rd way you describe in the above video) if I am working off of a class library project and I need to use httpClient within it. Basically, all my API calls are in a class library project. Is there an optimal way of using httpClient in it because I am worried about port exhaustion? Thanks
@MilanJovanovicTech Жыл бұрын
If you can create one HttpClient, pass it a SocketsHttpHandler instance at creation with some connection lifetime, and store it in a static field so that it's long-lived - that should suffice
@ramprahalad5579 Жыл бұрын
@@MilanJovanovicTech , got it! It is that oldish pattern of using the HttpClient I guess. Thanks a lot!
@floralb5317 Жыл бұрын
Hello Milan, Thank you for amazing content. Something is bothering me regarding the configurations you need for a HttpClient. Let's say that you have some configuration stored in Azure Key Vault/Azure SQL Database, and each incoming request to our API has some kind of x-clientId header, how would you handle creating named HttpClient or strong typing HttpClient after retrieving some metadata on Azure Key Vault/Azure SQL? Thank you, keep up the good work :)
@MilanJovanovicTech Жыл бұрын
I would explore an option of using a DelegatingHandler, to access Key Vault or SQL and get the configuration value.
@haskell3702 Жыл бұрын
Awesome explanation , but I have a doubt how can I Mock the http call using the typed approach? I mean, I want to write a test for GetByUserNameAsync method where the internal httpClient simulates returning 200 and a predefined json
@MilanJovanovicTech Жыл бұрын
Check this out: github.com/skwasjer/MockHttp
@pmsivakumar Жыл бұрын
How do you do when you need to fetch the access token dynamically and refresh when it expires with this approach?
@MilanJovanovicTech Жыл бұрын
Check this out: kzbin.info/www/bejne/laaZp2d6a9aaeqs You need a DelegatingHandler on top of the HttpClient
@codingbloke Жыл бұрын
Typed clients has too many gotcha's. In addition to the messy stuff you added at the end, what if you have multiple services that require the same HttpClient configuration? I just used named configurations and only inject the factory, simples.
@MilanJovanovicTech Жыл бұрын
You'd configure the services separately
@codingbloke Жыл бұрын
@@MilanJovanovicTech Indeed but then what you would have is all that malarkey to provide a specific configuration of a HttpClient which is only ever used by a single type and that type's only job is to wrap a specific configuration of HttpClient. In that case again you might as well have that service type do all that work. It would take the factory and what other config services it needed, and have a private method that returns a configured HttpClient
@bahmansani3408 Жыл бұрын
why can not find video about creating read models eventualy with eventual consistency?
@MilanJovanovicTech Жыл бұрын
It's a recent video, look for Materialized views
@vishalsaini-py4yd Жыл бұрын
Great video....can you please tell how I can configure multiple http client having different token mechanism and adding different authorisation header in each separate request.
@MilanJovanovicTech Жыл бұрын
You can use a delegating handler for each client
@KhinSandarMyint-eq2ks11 ай бұрын
May I know how to add dynamic certificate using HttpClientFactory ? I have to use different certs.
Based on that service, how do you write tests now to test that the httpclient got called once with x url?
@MilanJovanovicTech6 күн бұрын
Functional testing. Or you can mock the message handler with something like this: github.com/richardszalay/mockhttp
@EvgeniyYatsenkoАй бұрын
great stuff!
@MilanJovanovicTechАй бұрын
Thanks!
@juke-duke Жыл бұрын
What if you make the typed client a static class with a static HttpClient?
@MilanJovanovicTech Жыл бұрын
That works cool, since clients should be long-lived (at least the underlying message handler)
@semen083 Жыл бұрын
It is need to add "using" for httpClient, received from IhttpClientFactory?
@MilanJovanovicTech Жыл бұрын
No need, it'll be garbage collected
@elfatel Жыл бұрын
Thanks
@MilanJovanovicTech Жыл бұрын
You're welcome!
@pitthp6 ай бұрын
What is good configuration for PooledConnectionLifeTime for Integration test project, that have a hundred test with API calls?
@MilanJovanovicTech6 ай бұрын
How long does it take for your test suite execute?
@AmirHashemZadeh Жыл бұрын
well done
@MilanJovanovicTech Жыл бұрын
Thanks!
@user-tk2jy8xr8b Жыл бұрын
It's a pity that AddHttpClient forces you to use service locator pattern
@MilanJovanovicTech Жыл бұрын
You win some, you lose some
@adriancamposteixeira5483 Жыл бұрын
why not the "using" or "dispose"?
@MilanJovanovicTech Жыл бұрын
Not needed
@lucid111lucid7 ай бұрын
My use case is a DLL which will be used with a winforms program. I expect that my DLL will be called periodically (hourly) and occasionally for a short burst of http activity. What video do you have that might help me choose the best implementation method? /Rob
@MilanJovanovicTech7 ай бұрын
"short burst of http activity" - it doesn't look like you can do much harm whichever implementation you opt for. You could create a static HttpClient in the DLL and reuse it.
@zfold4702 Жыл бұрын
Now extend this for clients that need to send Jwt Token in headers with refresh token capability
@MilanJovanovicTech Жыл бұрын
Will do, that requires Delegating Handlers
@MahmoudSaed98Ай бұрын
why didn't you use Try - Catch to Handle Exceptions that may occur
@MilanJovanovicTechАй бұрын
Didn't need it for this example
@sanilkumarn.s8974Ай бұрын
Hello, Is it possible to inject httpclient in .net framework 4.8?
@MilanJovanovicTechАй бұрын
Yes, I believe it's available in .NET Framework (and recommended)
@Alaa_vieАй бұрын
Whats the difference between HttpClient and WebClient?
@MilanJovanovicTechАй бұрын
WebClient is obsolete and shouldn't be used: learn.microsoft.com/en-us/dotnet/api/system.net.webclient?view=net-8.0
@Alaa_vieАй бұрын
@@MilanJovanovicTech thank you
@thecodeman_ Жыл бұрын
Admit that you saw my post a few minutes ago, and in 20 minutes you recorded a 12-minute video, edited and uploaded it. Just admit it, I'll forgive you..