I Found the Perfect Open Source React Project (Code Review)

Рет қаралды 66,644

Күн бұрын

Пікірлер: 44

@curiouslycory 5 ай бұрын

They did so many great things but the lack of "src" directory makes me so uncomfortable. I wonder if there's a discussion somewhere that explains the thinking because that would be amazing. Mixing camel case and kabab case for files is also unnecessary clutter. Why would you want contributors to have to decide which to use each time?

@lebronjaimeslannister 5 ай бұрын

+1 on this

@mrbutish 5 ай бұрын

Because every single folder added is a potential ../path/ for imports, also you can only manage your own files case, on a big project it is inevitable someone will mix camel case and hyphens in their functions, variable names, file names, metadata configuration while working between python and JavaScript and Java naming conventions

@curiouslycory 5 ай бұрын

@@mrbutish You can add a linting rule that prevents mixed case. Define once, no longer inevitable. Clean code and project structures allow us to more quickly find files, read code, and spot problems thanks to the way the human brain does pattern matching. It also helps avoid decision fatigue by making file and variable naming a smidgen easier.

@rand0mtv660 5 ай бұрын

@@curiouslycory yeah setting it up as a lint rule just also lets reviewers focus on other important things and not kebab vs camel case conventions during reviews. Let linters do this boring work that's prone to errors and easy to overlook, but hard and tedious to enforce manually.

@viperactual 5 ай бұрын

You can still use a "src" directory.

@guddisAlex 4 ай бұрын

I looked into the code and really liked all the stuff they put in and how they structured their project... really clean! One thing I dont know about is having all components in index files, isnt it hard to search for files or not?! Another thing i dont know about is to use const and FC do define components?! Why not just a normal function? The overuse of arrow function in const i dont like generally... I tend to use const only if I really need it. Having your functions in actual functions it does not matter where you have it in your component, but nowadays everything has to be in a const var, which originally was meant to define constants ;) And I dont even think they used the pages folde ras the pages router, I think they just used the folder to organize their markdown files or no?!

@YancyGarretSaac 5 ай бұрын

Thank you for this video! I was requesting this kind of content on discord a month ago 😊

@JesseStrangfeld 5 ай бұрын

The reason for the higher-order components is to be able to use them directly in the MDX files. By embedding React components into the Markdown, authors can dynamically add or remove components from the page rendering without having to change any coding.

@akashthoriya 5 ай бұрын

Suggest more such projects, because it's hard to find good open-source react projects

@mani_naik 5 ай бұрын

Is there some open source react project with redux ?

@kizigamer6895 5 ай бұрын

My doubt why use nextjs for this and not use Astro for it which will have better md support

@muhammadyousufhere 5 ай бұрын

Vercel is being kind to nodejs

@pryff9569 5 ай бұрын

What do you think about the WSD architecture in large React projects?

@ShailendraSingh-cd2ln 5 ай бұрын

As always your videos are really good.

@stvn-light 5 ай бұрын

How do you make your videos so smooth? What are you recording this video with?

@cosdensolutions 5 ай бұрын

Screen studio

@m12652 5 ай бұрын

This project won't run for me, just get a bunch of module not found errors all pointing to shiki/langs/... Also... it uses a whole bunch of google api's and fonts, not good practice for production from my perspective. Would be interested to see something similar for sveltekit 👍

@PaweSmoka 5 ай бұрын

It is not bad, nicely configured and a lot of ready to use solutions, yet it is far from being perfect (for example issues: default exports, no community based dir patterns, could use signals instead of hooks etc, global styles /a lot of it/, too generic naming / hooks, util /, no module based split so types are global etc. etc.. )

@faez322 5 ай бұрын

Like your PERSIAN tattoo bro!😍

@Govind_rana500 5 ай бұрын

That's Arabic script

@faez322 5 ай бұрын

@@Govind_rana500 Thats PERSIAN. google it. این نیز بگذرد

@codealireza 5 ай бұрын

@@Govind_rana500 arabic and persian using the same script almost but totally different languages and his tattoo is in persian language which says "this too shall pass"

@jaspervandenbroucke1277 5 ай бұрын

Hey, what are some problems in web/software development that companies/developers can face these days? I ask this because I have to do some research on a specific problem in IT.

@meowWeee 4 ай бұрын

can you share your react course in other platforms like codedamn, udemy some other

@chadrackkyungu2167 5 ай бұрын

Wow thank you for the video, I have been looking to learn how to structure the application to a point where it can scale , again thank you so much love it

@Amirthanand 5 ай бұрын

Whats a "__foldername__" convention for ?

@Yusuffsmartt 5 ай бұрын

Amazing boss thanks for this

@Jay-pj7ob 5 ай бұрын

Please change the file icons theme to material icons, if possible

@mrkaif2359 3 ай бұрын

thanks for finding this repo😊

@nemeziz_prime 5 ай бұрын

This is so cool! I really like how you teach the best practices for React using live real-world examples to explain how to organize code and write good code. I believe writing code is one thing, but organizing code is as important as writing code. Maintainibility ftw xD Once again thanks a lot!