Laravel Code Review - This developer didn't get the job...

In this video I will do a Laravel junior code review of a project a junior developer submitted for a job interview. We will go through some common mistakes and 2 main reasons why he "failed" this coding challenge.
So, stick around to find out what he could have done differently to increase his chances to nail that interview.
I offer free code reviews as a way to give back and share my knowledge with the community. So, please feel free to reach out if interested. My contact details are available on the channel's about page / @codingwithpixelfix
Please join our code review community on Reddit.
/ laravelcodereviews
Facebook group where you can get some code support:
/ codingwithpixelfix
The Github link to the refactored code and pull request to highlight the improvements.
github.com/pix...
#laravel #codereview #webdevelopment

[@CodingWithPixelFix]

Junior developers: Please don't be afraid to share your code. Senior developers: Please share your knowledge and help those who are passionate about our industry.

[@ajomehri]

Great review but I have 1 misunderstanding: Is it nice & clean to have Route:view among routes? Or should be always routed back to Controller level first and then back to View? I mean is it easy to maintain such code in the feature for next developers? For example out of nowhere Company wanted more details on index page such as user details(name, GEO location, ...) to be loaded from database so that everything needs to be changed then? what about SOLID then?

[@CodingWithPixelFix]

@@ajomehri Thank you. I would say it depends on the project size. For small projects with one or two controllers, I would say it is perfectly fine to use Route::view in the routes. For a larger project that has loads of controllers and hundreds of routes, I would not use Route::view and I would use the actual controller method to return the view. The reason for this is purely to be consistent because it could get confusing if you start mixing the way you return your views. This is a personal preference and it is perfectly fine if you want to keep using Route::view in larger projects.

[@ajomehri]

@@CodingWithPixelFix Exactly Tnx for reply and hepful notes you mentioned

[@AndersFloor]

These code reviews are great, they really help ppl to become better programmers.

[@CodingWithPixelFix]

Thank you and yes, I totally agree. Code reviews are a great way of learning through practical examples. Even now, I also still learn things when I look at other people doing code reviews.

[@oketafred]

Awesome reviews, I'm new here. Cheers from Uganda

[@CodingWithPixelFix]

Thank you mate! Glad to have you here.

[@marcelodheni]

thank you for the tips, i'm new here. Cheers from Brazil.

[@CodingWithPixelFix]

Hi from Australia. You're welcome and I am always happy to help 🙂👍

I would like to ask: is the size of this project enough? It's only 1 controller, no database, etc. I'd imagine you need something more to showcase your work?

[@CodingWithPixelFix]

Yes, coding tests like these differ from company to company. These tasks normally require you to use the majority of Laravel features the company use in their product or platform. Most of them only give you a short amount of time to complete a list of tasks. The main idea behind tests like these is to check the quality of work instead of the quantity of work.