Top K Frequent Elements - Bucket Sort - Leetcode 347 - Python

  Рет қаралды 578,485

NeetCode

NeetCode

Күн бұрын

Пікірлер: 518
@Xeoncross
@Xeoncross 2 жыл бұрын
I appreciate the time you put making and sharing all your content for free. Here is the $10 I might have spent on your udemy course.
@NeetCode
@NeetCode 2 жыл бұрын
Thank you so much!!!
@onlysubscriptions2152
@onlysubscriptions2152 Жыл бұрын
Does he have udemy course???
@PeterPan-xe7qw
@PeterPan-xe7qw Жыл бұрын
@@onlysubscriptions2152 nah, just a hypothetical $10 he would’ve spent since most people pay wall this content, but he does it for free.
@hamdi_
@hamdi_ Жыл бұрын
As a side note, consider donating directly to the creators if they have a donation link, because KZbin takes a whopping 30% of your donation. In this case, Neetcode accepts Patreon donations, which takes a more reasonable commission of about 8%.
@mostinho7
@mostinho7 Жыл бұрын
@@hamdi_even 8% is too high tbh. Not for neetcode specifically, he sells his own courses and is set. But for someone else who might be in need of the money 8% is ridiculous
@rhitamdutta1996
@rhitamdutta1996 9 ай бұрын
I have never practiced DSA in my life, not even in college. After getting laid off, I stumbled across your videos to learn DSA. They are so crisp, informative, and to the point. I can't thank you enough.
@e889.
@e889. 8 ай бұрын
Hi you got any job?
@rhitamdutta1996
@rhitamdutta1996 7 ай бұрын
@@e889. not yet.
@ozgurpeynirci4586
@ozgurpeynirci4586 5 ай бұрын
Update?
@rhitamdutta1996
@rhitamdutta1996 5 ай бұрын
Hey guys, yes I did. Wouldn't have been possible without Neetcode.
@hamza-chaudhry
@hamza-chaudhry 4 ай бұрын
@@rhitamdutta1996 Nice
@rohananjaria1009
@rohananjaria1009 3 жыл бұрын
Best youtube channel for leetcode problems hands down.
@maierdanefan6998
@maierdanefan6998 3 жыл бұрын
Amazing contents! The best algorithms channel that focus on logic and thinking in a clear way. Happy to have found this channel, been writing neetcode ever since.
@joshmarion8640
@joshmarion8640 2 жыл бұрын
Am I the only one who is a little confused as to how this solution is O(N). If you loop through the array which is the size of the array, and then in each index you might have to loop through up to N times. So how is this not o(n^2) Edit: Nevermind, I think I realize it now, I figured I would write it out for anyone who might still be confused. As we traverse through the array, we go through the whole array. So this is O(n). But we aren't doing an operation n times at each stop. We are doing N more operation throughout the entire array. So even though the for loops are nested, we are doing N more operations throughout a for loop which is N, so the total is just N+N, which simplifies to O(N)
@abhishekdhyade7500
@abhishekdhyade7500 Жыл бұрын
Thanks a lot buddy! I was scratching my head off to find out this same doubt. Now that I saw your comment, I was able to understand it. Thanks again!!
@ahmedmansour5032
@ahmedmansour5032 Жыл бұрын
So essentially the inner loop is just operating on the subset of N elements?
@quanmai5759
@quanmai5759 Жыл бұрын
I would say it's n+k rather than n+n, because the size of the res array is k. So after looping through the freq array of size n, you only need to fill the res array k times then stop, so k more operations. Still it's O(n)
@ubermensch_1111
@ubermensch_1111 Жыл бұрын
@@quanmai5759 Yah I also think so it will be n+k
@DiaaHaresYusf
@DiaaHaresYusf Жыл бұрын
@@ahmedmansour5032 but at worest case you will face frequency = 1 for each element in nums .. and O(N) is always calcualted in worest case, I have made a commend on video please go through it , you will understand what I am saying
@justsimple6333
@justsimple6333 2 жыл бұрын
i used your previous video on groupAnagrams to solve this, just hashmapped the array in to a defaultdict(int) den sorted the dictionary entirely in a descending order. Your videos have been really helpful, first time i solved a medium all by myself
@trenvert123
@trenvert123 Жыл бұрын
That's so cool that python has a convenient way to sort hashmap by value. I looked into it for java, and it is a nightmare. I would have to create my own comparator. I think if I'm doing that, I may as well just learn bucket sort at this point.
@robinfelix3879
@robinfelix3879 Жыл бұрын
haha, did the same, cheers
@moveonvillain1080
@moveonvillain1080 Жыл бұрын
@@trenvert123 Java is sooooo verbose......
@Albert-nc1rj
@Albert-nc1rj 10 ай бұрын
@@trenvert123 In Go I faced the same problem, spent 20 minutes trying to sort a hash map by values (failed). So I just copied values into new array and sorted them there lol.
@dumdum407
@dumdum407 8 ай бұрын
@@Albert-nc1rj you can also insert the contents of your hashMap into a second hashMap, but use the values from frequency hashMap as the keys of the second hashMap. Once you have done that, take all the keys out into an array, sort the array and retrieve first k values, use first hashMap to get integers and return that.
@Number_Crunch
@Number_Crunch 2 жыл бұрын
The algorithm that you explained at 3:15 was counting sort and not bucket sort. What you did, however, towards the end was similar (not same as) bucket sort.
@namoan1216
@namoan1216 11 ай бұрын
is it different?
@chrischika7026
@chrischika7026 7 ай бұрын
@@namoan1216 no hes wrong
@donothack
@donothack Ай бұрын
@@chrischika7026 sorry, I'm confused. who is wrong? and wrong about what?
@sandeshpaudel9665
@sandeshpaudel9665 2 жыл бұрын
for the heap solution, it's better to use a min heap of size k rather than using a max heap and then removing max k times. Using the min heap, you would remove min and add the next frequency. by the end, you are left with k most frequent ones and removing the min gives you the answer. You can reduce this to n log k and not n log n
@gurmukhsinghnirman4935
@gurmukhsinghnirman4935 2 жыл бұрын
and even for values like k = 1e9, logk is around 30 so the complexity is around O(30*n) which is basically O(n)
@sandeshpaudel9665
@sandeshpaudel9665 2 жыл бұрын
@@gurmukhsinghnirman4935 indeed!
@PippyPappyPatterson
@PippyPappyPatterson 2 жыл бұрын
How would you cap the size of the heap `h` at size `k`? As you're adding frequencies, `if len(h) > k: heapq.heappop(h)`?
@sandeshpaudel9665
@sandeshpaudel9665 2 жыл бұрын
@@PippyPappyPatterson so let's suppose k = 3 and you have numbers [1 , 2 , 3, 4, 5]. You can find the k-largest or in this case 3rd largest using a min-heap of size 3. As you add in numbers, your heap can grow like this: [ 1 ] [ 1 , 2 ] [ 1, 2 , 3 ] ** you're capped at 3 *** [2, 3, 4] ** add next( 4 ) and remove min (1)** [3, 4, 5] ** add 5, remove 2 ** Now the head of the heap will be the 3rd largest element.
@MinhNguyen-lz1pg
@MinhNguyen-lz1pg 2 жыл бұрын
@@PippyPappyPatterson here class Solution: def topKFrequent(self, nums: List[int], k: int) -> List[int]: num_to_count = collections.defaultdict(int) for num in nums: num_to_count[num] += 1 min_heap = [] for num in num_to_count: if len(min_heap) < k: heapq.heappush(min_heap, (num_to_count[num], num)) else: heapq.heappushpop(min_heap, (num_to_count[num], num)) res = [] while min_heap: _, val = heapq.heappop(min_heap) res.append(val) return res
@Thrashmetalman
@Thrashmetalman 3 жыл бұрын
the one thing I dont like about usage of heap questions is that most of the times you havge to default to some library to do it cause I doubt any of us could code up a heap in a phone screen.
@tweefeety
@tweefeety 3 жыл бұрын
I love you man. You're an actual angel. Your explanations are always so clear. And your drawings are so easy to understand.
@NeetCode
@NeetCode 3 жыл бұрын
Thanks, appreciate the kind words 🙂
@fortitude242
@fortitude242 2 жыл бұрын
@@NeetCode you are n angel. :)
@wow_donnie
@wow_donnie 2 жыл бұрын
I came up with this solution originally but really appreciated the thoughtful description of the linear solution! result = defaultdict(int) for num in nums: result[num] += 1 result = dict(sorted(result.items(), key=lambda item: item[1])) return list(result.keys())[-k:]
@sentinel-y8l
@sentinel-y8l 2 жыл бұрын
While counting, you can keep track of the max occurrences and then you only need to initialize freq to that max instead of len(nums)
@amitkoushik5504
@amitkoushik5504 Жыл бұрын
Good one ...I spent a lot of time understanding this but finally got it..🤗🤗
@arneishprateek6444
@arneishprateek6444 Жыл бұрын
Sure but it's still O(N).
@s1kebeats
@s1kebeats Жыл бұрын
thx
@MrHarryGaming
@MrHarryGaming Жыл бұрын
count = {} maxFreq = 0 # or 1 for each in nums: count[each] = count.get(each, 0) + 1 maxFreq = max(maxFreq, count[each]) freq = [set() for i in range(maxFreq + 1)]
@awesome_ashu
@awesome_ashu 2 жыл бұрын
We can optimize it more by storing the maxFrequency while creating the HashMap (which has the integer and their corresponding frequency). Then, the next iteration to get the required elements can start from this maxFrequency instead of N.
@netanelkaye3014
@netanelkaye3014 11 ай бұрын
People say you are supposed to learn enough to be able to figure out leetcode problems, as opposed to memorizing leetcode. Are we seriously supposed to have been figured this method out? This was so specific...
@edd4851
@edd4851 7 ай бұрын
When you encounter a similar problem next time, you will think , well, i already saw it somewhere. I can do this.
@netanelkaye3014
@netanelkaye3014 7 ай бұрын
@@edd4851 Really? How many leetcode problems are solved this way?
@_carrbgamingjr
@_carrbgamingjr 6 ай бұрын
@@netanelkaye3014 1😅
@wotizit
@wotizit 6 ай бұрын
its best not to think about it lol
@beaglesnlove580
@beaglesnlove580 4 ай бұрын
@@netanelkaye3014none of
@VineetKrGupta
@VineetKrGupta 7 ай бұрын
I got my first job after following your neetcode 150, 2 years ago. now after the layoff i am here again learning the dsa.
@SharmaTushar1-yt
@SharmaTushar1-yt 6 ай бұрын
You can also use count = Counter(list) This will count in itself. No need for a loop. Another day thanking Guido van Rossum for making my life easier.
@johnzheng849
@johnzheng849 2 жыл бұрын
Your video got a me a job as an SDE at AWS!!
@NeetCode
@NeetCode 2 жыл бұрын
Congratulations 🎉🎉
@jwastken8814
@jwastken8814 2 жыл бұрын
Hey John, which neetcode 150 questions did they ask? I have a phone interview coming up
@Tejesh-t1t
@Tejesh-t1t Күн бұрын
@@jwastken8814 Hey jwastken, which neetcode 150 questions did they ask? I have a phone interview coming up
@mohamedeltawab
@mohamedeltawab 3 жыл бұрын
Your explanation is like art! Thank you!
@pinakadhara7650
@pinakadhara7650 2 жыл бұрын
Thanks for the video! I came up with the same solution except I assumed each element is "repeated unique number of times" from the problem statement - "It is guaranteed that the answer is unique.". So instead of looping over each lists, I just considered the first element.
@macro776
@macro776 29 күн бұрын
You can solve it even more efficiently in only 2 lines by being a python quack, although I doubt an interviewer would be pleased with it: count = collections.Counter(nums) # Creates a frequency counter from nums directly return [item[0] for item in count.most_common(k)] # Uses counter's most_common method
@tszyinshirleycheung4040
@tszyinshirleycheung4040 3 жыл бұрын
I think the runtime of using heap is O(n log k), we need O(n) to construct the heap and remove an item cost O(log k) ?
@MrACrazyHobo
@MrACrazyHobo 3 жыл бұрын
Yes, this is even what the leetcode official answers says
@michaelchen9275
@michaelchen9275 3 жыл бұрын
Isn't it O(log n) to remove from a heap with n elements? And we do that k times, so that makes O(k log n).
@theniknik0999
@theniknik0999 3 жыл бұрын
@@michaelchen9275 If we restrict the heap to be of size k (since we only care about k most frequent), at worst case we'll end up popping n elements. i.e. O(n log k)
@eulier1
@eulier1 4 ай бұрын
That's was a very interesting way to solve a specific real life problems, by counting and working with hash and array as a way to identify K most frequent elements. This can be useful for small to big business handling inventory or when you need to pack-up your stuff to travel.
@yarnehermann
@yarnehermann 2 жыл бұрын
I'm thinking you can just invert the frequencyMap to {frequency: list of values with that frequency} and then sort the keys in that inverted map. This sorting would be O(sqrt(n) log(sqrt(n))) (which is < O(n)) because there cannot be more than O(sqrt(n)) different frequencies (if each value has a different frequency, then n = O(c * (c+1) /2), with c being the number of distinct frequencies). Then it's just a matter of iterating over the reverse sorted keys and adding values to a resultArray until that array reaches length k lookupDict = defaultdict(int) for n in nums: lookupDict[n] += 1 inverseDict = defaultdict(list) for key, v in lookupDict.items(): inverseDict[v].append(key) sortedKeys = sorted(inverseDict.keys(), reverse = True) sortedKeysIndex = 0 res = [] while k > 0: values = inverseDict[sortedKeys[sortedKeysIndex]] if len(values) > k: res.extend(values[:k]) else: res.extend(values) k -= len(values) sortedKeysIndex += 1 return res
@pragnyatata491
@pragnyatata491 Жыл бұрын
really love the approach taken, thank you
@gabrielfonseca1642
@gabrielfonseca1642 2 ай бұрын
This is still O(n) because of the for loop on line 2, but yeah it's slightly more efficient
@kwakukusi4094
@kwakukusi4094 2 жыл бұрын
I got a similar question on my onsite interview with amazon (not the same question but same concept). I did not know bucket sort so I used the sorting method. The interviewer said there was a way of getting a linear time complexity and I did not know what to do .
@symbol767
@symbol767 2 жыл бұрын
This is perfect, thank you bro, took me a while to understand this problem, gonna need to redo it without looking at the solution in a couple days. Thank you, liked and commented again to support
@naveennvnkumar4615
@naveennvnkumar4615 2 жыл бұрын
I am bit confused, at 12:25 and lines 12,13 wouldn't it become a N^2 solution if all the elements are distinct
@ParryHotter73
@ParryHotter73 2 жыл бұрын
yeah, the example he showed is actually the worst case and it may be O(n²) but we can't say n² cause we don't find n elements at every index, this is an exceptional and not like general nested loop
@naveennvnkumar4615
@naveennvnkumar4615 2 жыл бұрын
@@ParryHotter73 ok got it. thanks buddy
@JaydenSWE77
@JaydenSWE77 Ай бұрын
Solution is so smart. You taught me so much more about hashmap and the capacity of it. Thank you!
@randomystick
@randomystick 2 жыл бұрын
for the return function, an alternate way is to use the extend() method in python: res = [ ] ptr = len(frequency)-1 while len(res)
@kestiv2429
@kestiv2429 2 жыл бұрын
Result size will be wrong if len(frequency[-1]) > k I think
@vachannadupalli6133
@vachannadupalli6133 Жыл бұрын
@@kestiv2429 The question guarantees that there is a unique solution. Hence every time we extend the result array, at some point it will(has to be) be equal to k. If it were not guaranteed, then you would be right.
@xrdevelopment1390
@xrdevelopment1390 2 жыл бұрын
is it just me or after struggling on a particular part for a while.... then it hits!!!!! best feeling ever. NeetCode, I am following along every problem and have the confidence that I'll get my dream tech position. thank you, its the same feeling I had when I found out about khan academy in high school
@Milan-vi1bq
@Milan-vi1bq 2 жыл бұрын
we're both gonna get the dream job homie!
@SharmaTushar1-yt
@SharmaTushar1-yt 6 ай бұрын
Also, you can do res += freq[i] in line 13. The problem description mentions the solution will be unique. So, we know that all the elements added if will either match k or will be lesser. So, no need to run a loop.
@vdyb745
@vdyb745 2 жыл бұрын
I was wondering where you were going with the bucket. This is so clever !!! Brilliant !!
@akarsan9121
@akarsan9121 4 ай бұрын
questions: lets assume we have array [1,2,2,3,3,4,4,4] and k = 2. Then for first most frequent we will have 4 but what about the 2nd most frequent element? cuz count of both 2,3 is 2 so how do we decide which value to insert into our resulting list??? Please help ps: "The test cases are generated such that the answer is always unique." is this statement accounting for that edge case?
@gabrielfonseca1642
@gabrielfonseca1642 2 ай бұрын
Yes this wouldn't be included in the test cases because there are two solutions (2, 4) and (3, 4). However note that if k = 3, then (2, 3, 4) and (3, 2, 4) are both solutions, which is why the problem says to give the answer in any order
@saifmohamed1776
@saifmohamed1776 3 жыл бұрын
i didn't see any body came up with this solution in the discussion on leetcode , all of the solutions were use heap or may be some of them use quick select ; so i was afraid that i analysis my algorithm wrong but after watching you i know that i was right about my solution .
@CarlJohnson-iv7sn
@CarlJohnson-iv7sn 2 жыл бұрын
Infact the top solution in the discuss is using bucket sort itself.
@poptart007-b2r
@poptart007-b2r 2 жыл бұрын
I love how your videos are always so damn clear :) ! Thanks alot Btw, here is a weird(?) quicksort version that beats 93%: def topKFrequent(self, nums: List[int], k: int) -> List[int]: count=list(Counter(nums).items()) def quick(l,r): pivot,p = count[r][1],l for i in range(l,r): if pivot>=count[i][1]: count[i], count[p] = count[p], count[i] p+=1 count[r], count[p] = count[p], count[r] if p>len(count)-k: return quick(l,p-1) if p=ind]
@NeetCode
@NeetCode 2 жыл бұрын
Nice!
@heathergray4880
@heathergray4880 2 жыл бұрын
Mine beats 98.62 time and 90 on space and is two lines long :)
@lucaslau8379
@lucaslau8379 2 жыл бұрын
@@heathergray4880 would you share your code for learning please?
@denshaSai
@denshaSai 2 жыл бұрын
Got this question for google, what to do then if input is streaming (like a log)? guess we keep updating the count (histogram), and rebuild the freq array everytime?
@sammyj29
@sammyj29 2 жыл бұрын
Amazing content as usual!! But I still don't understand, why is it O(n) even if there are 2 nested for loops? Thanks for creating these helpful videos!
@nathanwailes
@nathanwailes 2 жыл бұрын
The inner "for" loop on line 13 generally won't be iterating through an O(n) list, but instead just the number of input numbers that occurred a particular number of times.
@sravankumar4195
@sravankumar4195 2 жыл бұрын
I think, in worst case, it will be O(n^2). Let's consider the case, nums = [1,2,3,4,5,6] and k =6, then on line 13 the inner loop freq[1] = [1,2,3,4,5,6] will iterate "n" times. But in Avg. case it is O(n).
@chanpreetsingh007
@chanpreetsingh007 2 жыл бұрын
@@sravankumar4195 nope its o(n) only.
@Logan-mj3wx
@Logan-mj3wx 2 жыл бұрын
@@sravankumar4195 I believe you are correct, in the worst case this would be O(n^2) for the situation you described. You have to iterate over the whole frequency list(size n) and then when you get to the solution set(in your case index 1) you have to iterate over n elements once more. I had the same thought
@SlakOffs
@SlakOffs 2 жыл бұрын
@@Logan-mj3wx What about, if instead of a for loop, you simply did res += freq[i]. Is that operation faster O(1)?
@KardboardCode
@KardboardCode Жыл бұрын
Hey everyone, I have one question. Why is this solution considered O(n) where n is the size of the nums array? Why are we not looking at the worst case complexity for lines 11-16 at 12:52 If all items are unique Line 12: i will iterate over the range (0 , n) //Size of freq is n+1 Line 13: if all items inside nums are unique, every item will be present at the first index This will lead to looping through the entire length of the array n => this gives us O(n^2)
@sangramshinde2211
@sangramshinde2211 2 жыл бұрын
nick white, kevin, neetcode best guys to get the perfect explanation...
@md-ayaz
@md-ayaz 4 ай бұрын
One thing to note in python. Please do not intialize like this ( if you are ) bucket = [[]] * (len(nums) + 1) this references to the same list and your output will be wrong. Use the bucket = [[] for _ in range(len(nums)+ 1)] , as mentioned in the video.
@atulkumar-bb7vi
@atulkumar-bb7vi Жыл бұрын
Trust me bro, you are amazing explaining things. Thanks a lot for such content. Pls keep posting..
@arungowda
@arungowda 2 жыл бұрын
We can do a little space optimization by having max(counts) size for bucket instead of nums.length
@LeetCodeSimplified
@LeetCodeSimplified 2 жыл бұрын
Good point!
@bundayyolayinka3352
@bundayyolayinka3352 2 жыл бұрын
My current status: Understands the Questions, Have an Idea of how to start (not how to finish), Watches just your drawing explanation, Realize what is missing, Writes the whole solution.
@anonymoustv8604
@anonymoustv8604 2 жыл бұрын
that's great man. Keep going
@pacomarmolejo3492
@pacomarmolejo3492 11 ай бұрын
keep grinding. You will get there
@devashishubale1565
@devashishubale1565 Жыл бұрын
I was solving 692, and I got AC, I remembered this video came back to this. Thanks for such detailed videos.
@yxngboypolo
@yxngboypolo 4 ай бұрын
11:42 you could also use `for i in reversed(freq):` and modify the code as needed
@sharvitomar3809
@sharvitomar3809 2 жыл бұрын
Firstly, thank you for being so amazing with your videos! Actually I was wondering in the for loop on line 12, since inside that loop we keep checking for the length of res, isn't that increases the time complexity from the linear expectation?
@jambajuice07
@jambajuice07 Жыл бұрын
nooo actually the inner runs only for n times . soo thats n(outer loop) + n(inner loop) = 2n which is O(n).
@geekydanish5990
@geekydanish5990 2 жыл бұрын
class Solution: def topKFrequent(self, nums: List[int], k: int) -> List[int]: _map = {} res = [] for num in nums: _map[num] = 1 + _map.get(num,0) heap = [(val,key) for key,val in _map.items()] for val,key in (sorted(heap,reverse=True)[0:k]): res.append(key) return res
@mgst4699003
@mgst4699003 Жыл бұрын
Thank you man! Blessed to have you!
@il5083
@il5083 2 жыл бұрын
The solution and thought process is genius! Can't come up with this optimal solution by myself, thanks a lot.
@fakruu
@fakruu 2 жыл бұрын
how does it work for negative numbers ? For eg : arr [ -1, -1] and k = 1
@nishanttripathy8275
@nishanttripathy8275 2 жыл бұрын
For the heap the time complexity should be n.Log(k) since the max size of the heap can only be k and n is the number of elements
@firasyousfi2269
@firasyousfi2269 Жыл бұрын
Nope, if you are using a maxHeap it will be k log n. Because for that you need to heapify the whole thing first so n elements would be in the heap. Then you would pop 'k' times from the heap of size 'n'. So O(k log n). This is Valid if you use a maxHeap!!! If you are using a minHeap then you would be correct, then the heap would have a max size of k as you said. And you would loop n times and push then poll when size reaches k.
@syedzami-ul-haquenavid9392
@syedzami-ul-haquenavid9392 2 жыл бұрын
The explanation was so amazing that I understood how to solve half way through the video!
@srinadhp
@srinadhp 3 жыл бұрын
Got the same question in one of the phone screens. I came up with map and heap approach. The interviewer asked for an optimization for memory. And, I could not think of any other solution. It costed me next round unfortunately. Only if I notice your solution!!!! :-( Again! Great explanation and "neat" solution!!
@harigovind11
@harigovind11 3 жыл бұрын
This solution is also not memory optimised. Using "min" heap instead of max heap with size k would be memory optimised.
@kobeissi721
@kobeissi721 2 жыл бұрын
@@harigovind11 Wouldn't it still be O(N) since you still need to add them to a map to store the frequencies?
@sampatkalyan3103
@sampatkalyan3103 2 жыл бұрын
@@harigovind11 "Using "min" heap instead of max heap with size k would be memory optimised. " can you explain how ?
@tanmay17061
@tanmay17061 Ай бұрын
there is also the approach of using k-th order statistic to solve this problem. It does not require the assumption that the value of the array elements is bounded (like linear sorting algorithms require).
@34535fff
@34535fff Жыл бұрын
Man I could not do it myself because I didn't understand problem clearly, after 50 seconds of the video I understand and did it with ease, thanks a lot. Now I am going to watch rest of the video to learn optimal solution)
@prithvirajchavan9186
@prithvirajchavan9186 2 жыл бұрын
So basically the map of frequency to values can actually be of size O(n*n)? The first 'n' is due to worst case frequency being 1 to n and the second 'n' is because at most 'n' numbers can have the same frequency of 1. I kinda understand how its not really O(n*n) and a bit less than that as the duplicates are being consumed into a single key, but its still more than O(n) right? Another observation: The only possible values of frequency that have a value attached to them are the subsets that add up to N. In the given example, 100 occurs once, 2 occurs twice and 1 occurs thrice, so sum of frequencies is actually 1+2+3=6 which is N in this case. So the worst case space complexity is actually O(n*length of longest subset of frequencies that sum to N). Dont really know how I ended up with a Subset Sum problem just because i couldnt justify the O(n) space complexity lol. Any clarifications are appreciated :D
@venkatshiva8275
@venkatshiva8275 5 ай бұрын
First of all thank you very much @neetCode for this amazing explanation. Anyone has suggestions or improvements on the below solution?? class Solution { topKFrequent(nums, k) { let countObj = {}; const resArr = []; let ctr = nums.length; for(const i of nums){ countObj[i] = (countObj[i] || 0) + 1; } while(ctr > 0){ for(const key in countObj){ if(countObj[key] == ctr && resArr.length < k){ resSet.push(key); } } if(resArr.length == k){ break; } ctr--; } return resArr; } }
@YNA64
@YNA64 2 жыл бұрын
Holy this is so much clearer than the quick select one.... Thank you so much
@ChristopherElwell
@ChristopherElwell 9 ай бұрын
But not constant space complexity
@avadheshsingh4255
@avadheshsingh4255 Жыл бұрын
without knowing what is bucket sort I was only able to come with the hashmap sorting solution thanks mate for the o(n) soln.. great explanation
@ARJUN-op2dh
@ARJUN-op2dh 2 жыл бұрын
More simpler way from collections import Counter def dx(nums: list, k: int): x = Counter(nums).most_common()[:k] ls = [] for i,j in x: ls.append(i) return ls
@WinnerSingh
@WinnerSingh Жыл бұрын
Well what mistake I did is - I watched other python tutorials What good thing happen is - I am watching your videos But you are geniuses you explain well but I have to watch two times every video to understand correctly. Thank you
@dharmatejabandaru3344
@dharmatejabandaru3344 3 жыл бұрын
Such an awesome explanation and solution. Thanks, Man! Love it.
@rohanaurangabadkar951
@rohanaurangabadkar951 7 ай бұрын
Best explanation this helped me in solving Top K Frequent Elements and Sort Characters By Frequency
@VarunMittal-viralmutant
@VarunMittal-viralmutant 3 жыл бұрын
The final array that you create may have a lot of holes. Say there are 1000 elements, but consisting of only 1's and 2's, then the list will be full of holes. It can be further optimized by keeping a 'max_freq' variable which will provide an upper bound on the size of the array. This max_freq can be updated while creating the hash-map.
@mearaftadewos8508
@mearaftadewos8508 2 жыл бұрын
or may be this may not be the most efficient way to do this for all kinds of inputs like the one you said and unsorted numbers. It doesn't give the top frequent one's. Dictionary with maxheap is the one that can handle all possible inputs.
@shivani5882
@shivani5882 2 жыл бұрын
Hey! Could I receive a bit of clarification please? Why is your approach at 3:10 not O(n)? I thought it would be as would first need to find the max value in the given array (nums), then create our bucket array with that number as the upper limit? But since max( ) takes O(n) time - I'm quite confused. Thanks in advance!
@chesea9790
@chesea9790 10 ай бұрын
Awesome video! One small thing, shouldn't it be O(n log k) instead of O(k log n) for the heap solution since there's n elements, heap of size k means log k time to heapify and n calls so n * log k?
@AustinCS
@AustinCS 7 ай бұрын
Yes, it isn’t O(n) like he said
@johnzheng849
@johnzheng849 2 жыл бұрын
Thanks!
@NeetCode
@NeetCode 2 жыл бұрын
Thank you so much John!!
@akagamishanks7991
@akagamishanks7991 Жыл бұрын
how are the last two nested for loops at 11:30 only require O(n) + O(n)? Dont nested for loops always require O(n^2)?
@kobeyang4390
@kobeyang4390 Жыл бұрын
Typically yes, nested loops usually require O(n^2), but here is a special case. This is because the total number of values in each sublist of the frequency array will add up to n. Some 'buckets' may have no values in them. In total, you're looping through the frequency array, then looping through each sublist, whose total lengths add up to n. Overall, it's O(n + n) and NOT O(n * n), meaning it is still O(n).
@akagamishanks7991
@akagamishanks7991 Жыл бұрын
Cheers fam @@kobeyang4390
@theornament
@theornament 10 ай бұрын
I did the solution with priority queue and hashmap and it seemed to have better time complexity and space efficiency than using bucketsort. I feel like this is tricky because, when we are solutions for problems, we start analyzing which data structure we are going to use, its time complexity, etc. based on how those data structures are regularly implemented. The thing is, algorithms and built in functions in languages have improved drastically that they take less time than what theoretically they should take. It's tricky but are those are things that we should consider as well?
@BEEFnCHEESE44
@BEEFnCHEESE44 2 жыл бұрын
Thank you so much, your explanations are so easy to understand, I would be lost without you
@ShreksSpliff
@ShreksSpliff 6 ай бұрын
Watching this after attempting on NeetCode is soooo good!
@rajivshah3661
@rajivshah3661 Жыл бұрын
Just a question, What if after building the hashmap, we sort the dictionary by values using sorted() and return k keys?
@hype-r3076
@hype-r3076 Жыл бұрын
The sorted() is done in O(N log(N)). Although ur solution is correct it’s not the most efficient
@hype-r3076
@hype-r3076 Жыл бұрын
And in worst case N^2
@rakshitkumar1141
@rakshitkumar1141 2 жыл бұрын
I think your solution is O(n2). because in last part you performed n operations inside n. for i in range(len(freq) -1, 0, -1): ==== O(n) for n in freq[i]: ==== O(n)
@areelkhan4004
@areelkhan4004 Жыл бұрын
Thanks
@mehmetnadi8930
@mehmetnadi8930 2 жыл бұрын
I'm speachless! thank you, NeatCode!
@tanayshah275
@tanayshah275 3 жыл бұрын
Made it simple but efficient as always!
@mohamadilhamramadhan6354
@mohamadilhamramadhan6354 Жыл бұрын
Damn. I solve this problem for hours and a lot of code. It turns out could be this simple. Thankss, I learn something new. THE BUCKET SORT 😇
@shawnlin9873
@shawnlin9873 2 жыл бұрын
I used a dict to maintain the num->occurance pair for all items. Barely got the AC but the sorting part threw me off...had to use a lambda function to sort the dict by value. The optimal solution is a lot more subtle. Great content, very informative and well explained.
@lemonke8132
@lemonke8132 2 жыл бұрын
i did the exact same thing lmao
@HimanshuPant-c1v
@HimanshuPant-c1v 3 ай бұрын
this is how i did it, i basically converted the list in a dict, sorted it using values and the took out the k most frequent values but i really appreciate your videos. class Solution: from collections import Counter def topKFrequent(self, nums: List[int], k: int) -> List[int]: value = [] my_dict = dict(Counter(nums)) my_dict2 = dict(sorted(my_dict.items(), key=lambda item: item[1], reverse = True)) mlis = list(my_dict2.keys()) for i in range(k): value.append(mlis[i]) return value
@cakecup-r6g
@cakecup-r6g Ай бұрын
whats the time and space complexity of you solution bro, thanks btw
@ashadahmad651
@ashadahmad651 Жыл бұрын
Cannot believe I figured this on my own, definitely took some time but I was able to figure it out on my own.
@taekwondoman2D
@taekwondoman2D 2 жыл бұрын
Hey man, great videos and I appreciate neetcode a lot. I had a question about this in Java though. I tried to implement the buckets with an ArrayList of Arraylists but the algorithm was really slow. Do you have java code for this to compare to? I see you have it posted but using a different algorithm than this bucketing strategy. I would love to see how this is actually done efficiently in Java with this method in particular.
@TechOnScreen
@TechOnScreen 2 жыл бұрын
i have done the same but getting indexout of bound error. also can you tell how to append value of arraylist by adding new int to it. List li=new ArrayList(nums.length+1);
@normanfung7124
@normanfung7124 Жыл бұрын
Simpler approach: def topKFrequent_simplest(nums: List[int], k: int) -> List[int]: count = {} # key: n, value: count of n for n in nums: count[n] = 1 + count.get(n, 0) count = [(k, v) for k, v in count.items()] count.sort(key=lambda entry : entry[1], reverse=True ) return [ entry[0] for entry in count[:k]]
@lonen3rd
@lonen3rd Жыл бұрын
Awesome solutions as always. Worked on an alternative solution using a PriorityQueue. from queue import PriorityQueue def topKFrequent_2(nums, k): if not nums: return [] freqs = {num:nums.count(num) for num in nums} q = PriorityQueue() for num, count in freqs.items(): q.put((count, num)) qsize = q.qsize() while qsize > k: q.get() qsize -= 1 res = [] while q.qsize() > 0: vv = q.get() # will return (count, num) res.append(vv[1]) return res
@MistaT44
@MistaT44 2 жыл бұрын
This solution blew my mind! excellent video as always :)
@ronakpatel7911
@ronakpatel7911 Жыл бұрын
What I don't quite understand is that when I implemented this solution, the speed and memory is not as efficient compared to my initial solution in ``` class Solution: def topKFrequent(self, nums: List[int], k: int) -> List[int]: count = {} for num in nums: count[num] = 1 + count.get(num, 0) res = sorted(count, key = count.get, reverse = True) return res[:k] ``` Even though using sorted() here causing it to be n log n... Can someone explain why this one is appearing to be much quicker than the solution in the video?
@pruthvipegasus
@pruthvipegasus 8 ай бұрын
sorted() uses quick sort which has O(n log n) time complexity in the python interpreter.
@hiota45
@hiota45 4 ай бұрын
I used a dictionary and pair of while loops in python. Basically, while the nums list > 0, I would .pop the 0th number off the list and check to see if the number was in the dict as a key. If it was, add one to the value for that key. If not add it to dict as a key with a value of one. When the nums list was exhausted, another while loop for k > 0. Use the python max function to give a variable equal to the key with the highest value. Add that key to the results list, set the key value to 0, and -1 on k. I'm a novice though so this may be suboptimal?
@freddy5638
@freddy5638 3 жыл бұрын
My man! I've spent HOURS watching you. FYI you can do the counter with collections, and save few lines of implementation
@yossarian2909
@yossarian2909 2 жыл бұрын
How is that?? Can you pls share
@hamzasayyid8152
@hamzasayyid8152 2 жыл бұрын
@@yossarian2909 from collections import Counter, then Counter(nums) gives the frequency dict
@balavikashkandukuri6139
@balavikashkandukuri6139 2 жыл бұрын
@@hamzasayyid8152 continue the code
@leetcodemermaid9804
@leetcodemermaid9804 2 жыл бұрын
For the first heap solution, you can do a total complexity of n Log(k). Instead of heapify the whole dictionary ,you can heap push and heap pop when you go through the dictionary. When len(heap) > k, heap pop.
@MehmetDemir-xi3yy
@MehmetDemir-xi3yy 9 ай бұрын
nlogk generally bigger than klogn k=1200 and n=1500 nlogk ≈1500×3.0792≈4618.8 klogn=1200×log1500 ≈ 3811.2
@seanbarel2
@seanbarel2 8 ай бұрын
Is this solution also works when theres no limit on the values of the initial array? Or it assumes that the values in the array are bounded?
@vasumahalingam5162
@vasumahalingam5162 Жыл бұрын
Nice algorithm but it looks like it will fail when the nums list is [-1,-1] which makes c as -1 throwing index out of range exception.
@AndriiSobianin
@AndriiSobianin Ай бұрын
no because you have array size of 2, so your temp array is size of 3. in that case it will be 0,0,-1
@alexanderk5399
@alexanderk5399 Жыл бұрын
The best explanation I've seen! Thank you so much man!
@acecool1715
@acecool1715 9 ай бұрын
Thank you for your time teaching. Can i ask what software you use for the black board in the background, or anyone know? Thank you all.
@TomerBenDavid
@TomerBenDavid 2 жыл бұрын
Is the bucket sort always about having the number of buckets as the size of the highest frequency number or which kind of bucketing we use in the standard bucket sort?
@tomskrovan6622
@tomskrovan6622 Жыл бұрын
I believe the length of the frequency/bucket array could be lower than len(nums) + 1 because of the rule that the # of distinct elements >= k. This tells us that there will be at least k distinct elems and since each one must have at least one frequency, no single number could occupy all len(nums) spots (unless k is 1). Therefore I think it could be further optimized (albeit minimally lol) to: freq = [ [ ] for i in range( (len(nums) + 1) - (k - 1) ) ]
@ichigokurosaki7762
@ichigokurosaki7762 11 ай бұрын
Could you explain how the for loop works within the array, I didn't understand that part? Freq=[[] for i in range(Len(nums)+1)]
@sushmitchakraborty8781
@sushmitchakraborty8781 9 ай бұрын
I am still relatively new to data structures and algorithms,so pardon my newbie question. I noticed in the solution when appending to the 'res' list we have two for loops. Doesn't that count as o(n^2)?
@akashp4863
@akashp4863 2 жыл бұрын
is log(n) better solution than nlog(n) and log(n)?.... can you create a video on how to find big o and which one is better than which? i know there are many videos in youtube, but yours will be the best
@anujapuranik2000
@anujapuranik2000 Жыл бұрын
This is amazing explanation. Thank you for sharing this video.. Learnt something new today!
@dadisuperman3472
@dadisuperman3472 2 жыл бұрын
Actually there is a small improvement on this solution. Given the following observation: The length of the hashmap is the number of distinct elements in the array, all the rest are repetition of some or all of the elements of the array. So if we suppose that all elements are repeated only once except one elements is repeated enough to fill the array size, we can calculate the largest frequency achievable as follow: maxFreq = Len(arr) - Len(hashmap) + 1 that means the size of the frequency array is just : maxFreq, instead of len(nums)+1 freq = [[] for in in range(MaxFreq)] That was my 50cents contribution ;)
@mehrdadzamirian
@mehrdadzamirian Жыл бұрын
There is an edge case that is not covered in the code the can be considered by a simple 'if' condition. If the number of unique numbers in the array is smaller that the 'k', code will not return anything. can be solved by adding this line after the hash map dictionary: if len(count)
@joshuawilkins3656
@joshuawilkins3656 Жыл бұрын
the question states k
@tedtran7855
@tedtran7855 2 жыл бұрын
Clever solution! I came up with the nlogn solution immediately and thought the problem was over since the Leetcode page only wanted that. Then I watched your video and I was shook when you said there was an O(N) solution haha.
@StfuSiriusly
@StfuSiriusly 2 жыл бұрын
leetcode page says to find a solution that is BETTER than n log n
@Dhanushh
@Dhanushh Жыл бұрын
One can optimise the heap solution to O(nlogk). After creating dictionary, insert the keys into min heap of size k where element with less frequency is always at the top. When the heap is full, pop the less frequency element from the top of heap. Final heap elements are the answer. In this way, since you are maintaining only k elements in heap, each push and pop is o(logk), which you do n times in worst case - Hence O(nlogk)
@Yougottacryforthis
@Yougottacryforthis Жыл бұрын
how is this optimized? its strictly worse as n >= k
@Yougottacryforthis
@Yougottacryforthis Жыл бұрын
original solution was O(klogn)
Product of Array Except Self - Leetcode 238 - Python
11:54
NeetCode
Рет қаралды 662 М.
Top K Frequent Elements - Leetcode 347 - Heaps (Python)
14:08
Greg Hogg
Рет қаралды 12 М.
Мен атып көрмегенмін ! | Qalam | 5 серия
25:41
小丑教训坏蛋 #小丑 #天使 #shorts
00:49
好人小丑
Рет қаралды 49 МЛН
Sort Colors - Quicksort Partition - Leetcode 75 - Python
15:48
C Programming Tutorial for Beginners
3:46:13
freeCodeCamp.org
Рет қаралды 16 МЛН
How I Failed the Google Coding Interview (and lessons I learned)
14:24
High-profile elimination of a war criminal in Moscow
14:33
NEXTA Live
Рет қаралды 319 М.
TOP K FREQUENT WORDS| LEETCODE 692 | PYTHON CUSTOM HEAP SOLUTION
13:38
Cracking FAANG
Рет қаралды 3,2 М.
Subarray Sum Equals K - Prefix Sums - Leetcode 560 - Python
15:19
Making an Algorithm Faster
30:08
NeetCodeIO
Рет қаралды 172 М.
Top 7 Data Structures for Interviews Explained SIMPLY
13:02
Codebagel
Рет қаралды 239 М.