What's Wrong - .NET Practical Interview Question #3

In this series we will see short videos to identify bad coding practices and bad code!
Full Course (60+ interview Questions) : www.dotnetmastery.com/Home/De...
It is meant for anyone in .NET domain to improve their coding knowledge.
If you have some examples you want to share with the community you can send them here forms.gle/FUuLB7bRxsXgqiWH6
To see more in-depth full courses go to : dotnetmastery.com/
Support more free content? ☕ Coffee: www.buymeacoffee.com/bhrugen

[@dy0mber847]

Else statement should also be omitted because we are using return inside if, no need to use else in this case

[@DotNetMastery]

Indeed! But sometimes I like code readability over less code!

[@prateektomar4874]

I appreciate the series!!

[@ishaz11]

I like this series. Please keep it up

[@DotNetMastery]

Thank you will do!

[@oremichenjesumeichen7801]

This series is great 👍

[@TELUCODER]

The best video on KZbin channel till now keep posting these sir

[@DotNetMastery]

I will try my best

[@being_aslam_tiger]

Please Make a design pattern playlist. Like gang of four design patterns C#.

[@cavila0217]

Thanks for the tip!

[@DotNetMastery]

You bet!

[@pilotboba]

I guess my first question would be, if you don't want to allow a string, why do you use nullable string? I also don't see the routing definition for this. Also, I don't know if this is MVC5 or Core/Modern dotnet. So, I'm not sure how this would be called. Would it be: /Home/Index?userid= or /Home/Index assuming routing is used like /Home/Index/{userid} then if no user id is in the URL it won't even be routed to this endpoint. You can also use route constraints to eliminate the need to do the is empty check. Although, like I said, it looks like this is not using attribute routing. Also, wouldn't use ==null, but rather do pattern matching. Granted you used the IsNullOrEmpty which covers the null check. Finally, it's redundant to pass the view name if it matches the action name.

[@pilotboba]

Also, if you are using string? I assume you are using Null Refernce feature, because normally a string can be null, it's not a value type.

[@DotNetMastery]

Hello, in the example we are using the case when userid is not present to display a value of “No user id”

[@ajaymanav2010]

It would be good to create some good content..these are the basics that you have coverd in your videos and i believe every developer is aware of it ..let's contribute with some real and practical interview scenarios that would help